From owner-svn-src-all@FreeBSD.ORG Sun Dec 18 07:48:42 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 77122106566B; Sun, 18 Dec 2011 07:48:42 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail06.syd.optusnet.com.au (mail06.syd.optusnet.com.au [211.29.132.187]) by mx1.freebsd.org (Postfix) with ESMTP id C662C8FC0A; Sun, 18 Dec 2011 07:48:41 +0000 (UTC) Received: from c211-28-227-231.carlnfd1.nsw.optusnet.com.au (c211-28-227-231.carlnfd1.nsw.optusnet.com.au [211.28.227.231]) by mail06.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id pBI7mb9p000601 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 18 Dec 2011 18:48:38 +1100 Date: Sun, 18 Dec 2011 18:48:37 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: mdf@freebsd.org In-Reply-To: Message-ID: <20111218183813.H1383@besplex.bde.org> References: <201112171314.pBHDEjtQ060509@svn.freebsd.org> <4EED0F99.2020306@FreeBSD.org> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-563560353-1324194517=:1383" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric Subject: Re: svn commit: r228625 - head/usr.bin/csup X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Dec 2011 07:48:42 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-563560353-1324194517=:1383 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Sat, 17 Dec 2011 mdf@freebsd.org wrote: > On Sat, Dec 17, 2011 at 1:54 PM, Dimitry Andric wrote: >> On 2011-12-17 22:32, mdf@FreeBSD.org wrote: >> ... >>>> =A0In usr.bin/csup/auth.c, use the correct number of bytes for zeroing= the >>>> =A0shared secret, and use long long format to snprintf a time_t. >>> If casting is necessary, style prefers intmax_t or uintmax_t, since >>> those are always wide enough. >> >> I don't see anything about that in style(9), maybe it should be added >> then? style(9) decoments the uncouthness of long long and %lld by providing no examples of them. Unfortunately for my cause, it also provides no examples of intmax_t. It is basically just too old to provide examples of either. > Probably; Bruce has mentioned it many times in the past, and as bz@ I tried to get [u]intmax_t used, and [unsigned] long long and [u]quad_t killed, before C99, so that FreeBSD would never use the long long abomination. There was a problem printing the [u]intmax_t's before C99. I don't remember anything that would have worked except %q, and in userland, also %ll. %ll was intentionally left out of the kernel printf(), but this has been broken. > notes, it's a well-defined type with a well-defined conversion > specifier. Also, long long is a bit of a hack that came in before C99 s/a bit of/gross/ > standardized on a few wider types, and the PRIu64 macros are really > hideous. Bruce --0-563560353-1324194517=:1383--