From nobody Sun Sep 3 03:47:53 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rdd5f4crjz4s3ts for ; Sun, 3 Sep 2023 03:48:06 +0000 (UTC) (envelope-from jake@technologyfriends.net) Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rdd5f1p4Jz4FZ7 for ; Sun, 3 Sep 2023 03:48:06 +0000 (UTC) (envelope-from jake@technologyfriends.net) Authentication-Results: mx1.freebsd.org; none Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2bb9a063f26so4379791fa.2 for ; Sat, 02 Sep 2023 20:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=technologyfriends.net; s=google; t=1693712884; x=1694317684; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oGmwaX0jdaJ1v/MYpyfS1ZQAYN5uiSXRctE3ymcFnZI=; b=anHlnEHbw7MXWYav4Olil//o8cIybjmoycM9XekshZlKO+AKYh3sAr4rJkGTgKMhYt lhX+D7hpBoakkKWCG10XtBeyJ+OoRKGARuCh/Q7vKY++P2i1C5FCo2X4QhvoeZldLzJ0 Kv6j+YLBSi/R0YP1dT152R6jaWViD5SQK3PR5wK+7ufs9ZeOIQFgDrXgE2PzI41zd+s8 KJA90llh+VkUtghDHIrAQ2Dz3RpYhEGWI0h2YfIj8UWIDsw/G6OzSw9Bbpqk0IThNu+P PiMmblAQ9AFIdGGbwePo6boaBpyeo+aQkVOfJ+cBPsyboFpjL+rmN1uvq+1GdlFhqj2w +Xbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693712884; x=1694317684; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oGmwaX0jdaJ1v/MYpyfS1ZQAYN5uiSXRctE3ymcFnZI=; b=cTZ3RSTUEB+xxiwxHt5+xqcy79NpksNJBDDRjyzbUYsPQ/QJaE0oIZ9SNvwd++PQmM 6Rv/p10nSRIgGK3i40rt+5penb+y9QGTIfWlc4jFTtJexMabiKl+FAeF4+5oRPnkhImp xZQCNe252WHF79fvzB69exJvqIZ8h9bI9pX2FVQ5aEmCa8B/x4Y/rCztZPsvK/S1F/zI /lrSqH/MQDVtLsm+GdDxAU1qcjnAbQ8XSr60WAurngo4qGlx59M0q5dBlVTJ5l6pHFnG JawO2PHBvXcX2OZXyQdGqbNXM7GUqZSoFkkKCiLGMuBp0QB94WgSBIAps8TxotLCVbeO PEMw== X-Gm-Message-State: AOJu0YyVFPnPBq0R3iOTYIt7AIXnQZHGDE8jEXoNUZBSwqmgEyEmPtjO CBVkbwJdBSeaxw462eMJ7mFx8yQ+4UUp+lAHb1R1IOPBJnp9Zwo9du4= X-Google-Smtp-Source: AGHT+IE/iJ7JJb2XtJvTxldWK/4SE4nXs8u2pKkPN4yLeRhoFb5w+YilLuGcI8HNVcLzsDFQiFsPu9so96EvOJ5c0Kw= X-Received: by 2002:a2e:8610:0:b0:2b7:31a:9d7c with SMTP id a16-20020a2e8610000000b002b7031a9d7cmr4397939lji.33.1693712884492; Sat, 02 Sep 2023 20:48:04 -0700 (PDT) List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 References: <20230903123028.4ffceb705824f86d2efc21e3@dec.sakura.ne.jp> In-Reply-To: From: Jake Freeland Date: Sat, 2 Sep 2023 22:47:53 -0500 Message-ID: Subject: Re: Is there any plan for ZFS and timerfd updates on stable/14? To: Warner Losh Cc: Tomoaki AOKI , FreeBSD-STABLE Mailing List Content-Type: multipart/alternative; boundary="000000000000d4ffdf06046c423d" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4Rdd5f1p4Jz4FZ7 --000000000000d4ffdf06046c423d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Sep 2, 2023 at 10:40=E2=80=AFPM Warner Losh wrote: > > > On Sat, Sep 2, 2023, 9:36 PM Jake Freeland > wrote: > >> On Sat, Sep 2, 2023 at 10:31=E2=80=AFPM Tomoaki AOKI >> wrote: >> >>> Hi. >>> >>> There are discussions about deadlocks issue of ZFS on freebsd-current >>> ML, starting from [1] last month. >>> IIRC, at least some fixes (candidates?) are merged to main, but not yet >>> to stable/14. >>> >>> Upcoming (aleready released? or still rc3?) OpenZFS 2.2-release seems >>> to have most of them. So my 1st question is "Is there any plan to >>> import vendor/openzfs/zfs-2.2-release into stable/14 BEFORE BRANCHING >>> releng/14? >>> >>> And one more. timerfd is added at last-minutes BEFORE stable/14 is >>> branched, and already have not-yet-MFC'ed fixes [2], [3], [4] and >>> Differential revision D41600 on Phablicator [5] related to memory leaks >>> and locks. >>> Additionally, splitting out lib32 part to proper place is proposed >>> as D41640 [6]. Both [5] and [6] are accepted but not yet landed. >>> Also, D41641 [7] proposes namespace pollution adjustments. This can be >>> optional? >>> >>> Memory leaks and improper locks can lead system to security issues or >>> deadlocks, so it would be benefical if landed and MFC'ed BEFORE >>> releng/14 branches. >>> >>> Is there any plan to do so? At least, existing deadlocks should be >>> considered as SHOW-STOPPER and resolved. >>> >> >> The plan is to get all of those patches in before releng/14.0, I believe= . >> >> What are your thoughts, Warner? >> > > Sounds like the reviews are done or nearly so. I've not had time to look > closely to be sure... I'd planned on making time Tuesday morning. > Yes. All reviews are good to go. Jake Freeland > > Warner > > >> Thanks, >> Jake Freeland >> >> >>> >>> I myself am bitten by several deadlocks on poudriere full builds after >>> upgrading base from stable/13 to stable/14, finally finished with >>> increasing kern.maxvnodes after powercycle on each deadlock and >>> continue. >>> >>> >>> Thanks in advance! >>> >>> [1] >>> >>> https://lists.freebsd.org/archives/freebsd-current/2023-August/004162.h= tml >>> >>> [2] >>> >>> https://cgit.freebsd.org/src/commit/?id=3D02f534b57f84d6f4f97c337b05b38= 3c8b3aaf18c >>> >>> [3] >>> >>> https://cgit.freebsd.org/src/commit/?id=3D5eab523053db79b4bd4f926c7d7ac= 04444d9c1da >>> >>> [4] >>> >>> https://cgit.freebsd.org/src/commit/?id=3Df4296cfb409a48de00bfa60e76f68= 6c2b031876f >>> >>> [5] https://reviews.freebsd.org/D41600 >>> >>> [6] https://reviews.freebsd.org/D41640 >>> >>> [7] https://reviews.freebsd.org/D41641 >>> >>> -- >>> Tomoaki AOKI >>> >>> --000000000000d4ffdf06046c423d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Sep 2, 2023 at 10:40=E2=80=AFPM W= arner Losh <imp@bsdimp.com> wro= te:


On Sat, Sep 2, 2023, 9:36 PM Jake Freel= and <jak= e@technologyfriends.net> wrote:
On Sat, Sep 2, 202= 3 at 10:31=E2=80=AFPM Tomoaki AOKI <junchoon@dec.sakura.ne.jp= > wrote:
Hi.

There are discussions about deadlocks issue of ZFS on freebsd-current
ML, starting from [1] last month.
IIRC, at least some fixes (candidates?) are merged to main, but not yet
to stable/14.

Upcoming (aleready released? or still rc3?) OpenZFS 2.2-release seems
to have most of them. So my 1st question is "Is there any plan to
import vendor/openzfs/zfs-2.2-release into stable/14 BEFORE BRANCHING
releng/14?

And one more. timerfd is added at last-minutes BEFORE stable/14 is
branched, and already have not-yet-MFC'ed fixes [2], [3], [4] and
Differential revision D41600 on Phablicator [5] related to memory leaks
and locks.
Additionally, splitting out lib32 part to proper place is proposed
as D41640 [6].=C2=A0 Both [5] and [6] are accepted but not yet landed.
Also, D41641 [7] proposes namespace pollution adjustments. This can be
optional?

Memory leaks and improper locks can lead system to security issues or
deadlocks, so it would be benefical if landed and MFC'ed BEFORE
releng/14 branches.

Is there any plan to do so? At least, existing deadlocks should be
considered as SHOW-STOPPER and resolved.

The plan is to get all of those patches in before releng/14.0, I believe.=

What are your=C2=A0thoughts, Warner?
<= /div>

Sounds like the reviews are done or nearly so. I've not had time to lo= ok closely to be sure... I'd planned on making time Tuesday morning.=C2= =A0

Yes. All reviews are good t= o go.

Jake Freeland
=C2=A0

Warner


=
Thanks,
Jake Freeland
=C2=A0

I myself am bitten by several deadlocks on poudriere full builds after
upgrading base from stable/13 to stable/14, finally finished with
increasing kern.maxvnodes after powercycle on each deadlock and
continue.


Thanks in advance!

[1]
https://lists.f= reebsd.org/archives/freebsd-current/2023-August/004162.html

[2]
https:/= /cgit.freebsd.org/src/commit/?id=3D02f534b57f84d6f4f97c337b05b383c8b3aaf18c=

[3]
https:/= /cgit.freebsd.org/src/commit/?id=3D5eab523053db79b4bd4f926c7d7ac04444d9c1da=

[4]
https:/= /cgit.freebsd.org/src/commit/?id=3Df4296cfb409a48de00bfa60e76f686c2b031876f=

[5] https://reviews.freebsd.org/D41600

[6] https://reviews.freebsd.org/D41640

[7] https://reviews.freebsd.org/D41641

--
Tomoaki AOKI=C2=A0 =C2=A0 <junchoon@dec.sakura.ne.jp>

--000000000000d4ffdf06046c423d--