From owner-cvs-src@FreeBSD.ORG Fri Aug 4 01:25:17 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE8B816A4DE; Fri, 4 Aug 2006 01:25:17 +0000 (UTC) (envelope-from jb@what-creek.com) Received: from what-creek.com (what-creek.com [66.111.37.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B71743D46; Fri, 4 Aug 2006 01:25:17 +0000 (GMT) (envelope-from jb@what-creek.com) Received: by what-creek.com (Postfix, from userid 102) id B861578C1F; Fri, 4 Aug 2006 01:25:14 +0000 (GMT) Date: Fri, 4 Aug 2006 01:25:14 +0000 From: John Birrell To: pdeuskar@FreeBSD.org Message-ID: <20060804012514.GA63379@what-creek.com> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44D29FB6.9090209@freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cperciva@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 01:25:17 -0000 On Thu, Aug 03, 2006 at 06:15:34PM -0700, Colin Percival wrote: > Prafulla Deuskar wrote: > > Modified files: > > sys/dev/em if_em.c if_em.h > > Log: > > Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. > > This makes it easier for us to get the changes into -current and to -stable quickly. > > I assume you've discussed this with glebius, who made the original changes; in > the future, please add an "Approved by:", "No objections from:", or "Discussed > with:" line to backout commits to make this more clear. Also Pyun had made a fix for the bus_dmamap_unload problem we see on sun4v. This appears to have been backed out amongst what appears to be largely a white-space change. Are you prepared to do the work to solve the bus_dmamap_unload again? -- John Birrell