From owner-freebsd-ports@FreeBSD.ORG Sat Apr 28 01:35:38 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 94EE8106566C; Sat, 28 Apr 2012 01:35:38 +0000 (UTC) (envelope-from sendtomatt@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 55A1A8FC0A; Sat, 28 Apr 2012 01:35:38 +0000 (UTC) Received: by pbbro2 with SMTP id ro2so194828pbb.13 for ; Fri, 27 Apr 2012 18:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Cco6vG2WU0TRYeyPJ5fK5FoGzb6/doO1BLl1Y41OedQ=; b=tHQTyao2e4649nXVfc9vmKsn5otl+Vk1HEkXhWJkr++luX8r4fdDWlCTSz4Gvdf4y6 5/JdQ3XPseo8orwetjBHXxvi9J53WyIk694l+67NqUYoomUcF6e+IV9Q6wrGgLdCJeFF bDA4HYfgTOKyEk/Rqp9wLhjZJQHemZtw11EJgKaSbyEh/qkLwRpENji2d9jKos7ARoIr 8BLgEaBuFxXcpQE3y+M9hFt05NJ+7AS9G33nK6T1l9JPAi4Qry7c9C2do61r0XSqtTtb 9da3CegkL1QL392fcXzI3GxmDS1IQSuKuY7GhfYM7HKoPFC6XRmleC4XnPc/jIQ2ujAu iW4Q== Received: by 10.68.203.66 with SMTP id ko2mr8557249pbc.84.1335576937979; Fri, 27 Apr 2012 18:35:37 -0700 (PDT) Received: from flatline.local (70-36-223-239.dsl.dynamic.sonic.net. [70.36.223.239]) by mx.google.com with ESMTPS id nz8sm8073838pbb.68.2012.04.27.18.35.35 (version=SSLv3 cipher=OTHER); Fri, 27 Apr 2012 18:35:36 -0700 (PDT) Message-ID: <4F9B4958.9030007@gmail.com> Date: Fri, 27 Apr 2012 18:35:20 -0700 From: matt User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:11.0) Gecko/20120422 Thunderbird/11.0.1 MIME-Version: 1.0 To: Andriy Gapon References: <4F9541DD.3080200@netfence.it> <4F956713.60604@gmail.com> <4F979BCA.9050800@gmail.com> <4F98F3BC.3020305@gmail.com> <4F9AD153.4000103@FreeBSD.org> In-Reply-To: <4F9AD153.4000103@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Warren Block , x11@FreeBSD.org, freebsd-ports@FreeBSD.org Subject: Re: New X.Org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Apr 2012 01:35:38 -0000 On 04/27/12 10:03, Andriy Gapon wrote: > on 26/04/2012 18:45 Warren Block said the following: >> On Thu, 26 Apr 2012, matt wrote: >> >>>>>> Interesting. Another Radeon 4650 (rv730) is not working here, giving Bus >>>>>> Errors at the same address whenever certain applications are launched. >>>>>> Failing examples: Firefox, gedit, qt4-designer Successful: xfce4-terminal, >>>>>> ioquake3, compiz >>> Fixed this issue using the changes indicated in the below patch, which >>> solved my issue with x bus errors. It looks like glxGetScreen was >>> choking. This may help users with similar problems in compiz or Kwin. >>> FYI I manually applied changes in the patch to x11-servers/xorg-server, >>> not sure if the patch below would apply cleanly. >>> >>> diff --git a/glx/glxdri.c b/glx/glxdri.c >>> index 326f539..f6ef784 100644 >>> --- a/glx/glxdri.c >>> +++ b/glx/glxdri.c >>> @@ -230,7 +230,7 @@ __glXDRIdrawableDestroy(__GLXdrawable *drawable) >>> >>> /* If the X window was destroyed, the dri DestroyWindow hook will >>> * aready have taken care of this, so only call if pDraw isn't NULL. */ >>> - if (drawable->pDraw != NULL) { >>> + if (drawable->pDraw != NULL&& drawable->pDraw->type == DRAWABLE_WINDOW) { >>> screen = (__GLXDRIscreen *) glxGetScreen(drawable->pDraw->pScreen); >>> (*screen->core->destroyDrawable)(private->driDrawable); >>> >> Good catch! Please enter a PR for this! > Just double-check that this change doesn't introduce any memory/resource leaks :-) > Verifying this may be beyond my xorg-fu...what's the best way to examine this? Matt