Date: Mon, 28 Aug 2006 19:11:01 +0800 (KRAST) From: Eugene Grosbein <eugen@grosbein.pp.ru> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/102600: [patch] ports/net-mgmt/arpwatch's rcNG script does not handle 'restart' Message-ID: <200608281111.k7SBB1sF017577@nkz.delikates-nk.ru> Resent-Message-ID: <200608281120.k7SBKNjJ075299@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 102600
>Category: ports
>Synopsis: [patch] ports/net-mgmt/arpwatch's rcNG script does not handle 'restart'
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Aug 28 11:20:22 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Eugene Grosbein
>Release: FreeBSD 6.1-STABLE i386
>Organization:
Svyaz Service JSC
>Environment:
System: FreeBSD nkz.delikates-nk.ru 6.1-STABLE FreeBSD 6.1-STABLE #0: Wed Aug 16 20:09:18 KRAST 2006 sa@nkz.delikates-nk.ru:/home/obj/home/src/sys/NKZ i386
>Description:
ports/net-mgmt/arpwatch installs rc.NG script that does not
analyze 'arpwatch_interfaces' parameter during restart
and restartd arpwatch without needed arguments.
Second, it sets 'pidfile' variable but arpwatch does not create one.
>How-To-Repeat:
echo arpwatch_enable=YES >> /etc/rc.conf
echo arpwatch_interfaces=xl0 >> /etc/rc.conf
echo 'arpwatch_xl0_options="-m arpwatch"' >> /etc/rc.conf
/usr/local/etc/rc.d/arpwatch start
This starts arpwatch OK.
/usr/local/etc/rc.d/arpwatch restart
This restarts arpwatch without command line arguments.
>Fix:
This should be applied to ports/net-mgmt/arpwatch directory.
--- files/arpwatch.sh.in.orig Mon Aug 28 17:38:19 2006
+++ files/arpwatch.sh.in Mon Aug 28 17:38:43 2006
@@ -63,11 +63,10 @@
;;
*)
- if [ "$1" = "start" ]; then
+ if [ "$1" = "start" -o "$1" = "restart" ]; then
for interface in ${arpwatch_interfaces}; do
eval options=\$arpwatch_${interface}_options
command_args="-i ${interface} ${options} -f arp.${interface}.dat"
- pidfile="/var/run/arpwatch-${interface}.pid"
run_rc_command "$1"
done
else
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200608281111.k7SBB1sF017577>