From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Aug 28 11:20:44 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E032316A4DF for ; Mon, 28 Aug 2006 11:20:43 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3737A43D70 for ; Mon, 28 Aug 2006 11:20:24 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k7SBKOYi075300 for ; Mon, 28 Aug 2006 11:20:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k7SBKNjJ075299; Mon, 28 Aug 2006 11:20:24 GMT (envelope-from gnats) Resent-Date: Mon, 28 Aug 2006 11:20:24 GMT Resent-Message-Id: <200608281120.k7SBKNjJ075299@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Eugene Grosbein Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C11A16A514 for ; Mon, 28 Aug 2006 11:11:43 +0000 (UTC) (envelope-from sa@nkz.delikates-nk.ru) Received: from delikates-nk.ru (delikates-nk.ru [81.16.143.98]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0D1F43D6B for ; Mon, 28 Aug 2006 11:11:18 +0000 (GMT) (envelope-from sa@nkz.delikates-nk.ru) Received: from nkz.delikates-nk.ru (nkz [81.16.143.102]) by delikates-nk.ru (8.13.6/8.13.6) with ESMTP id k7SBB3Dn088550 for ; Mon, 28 Aug 2006 19:11:05 +0800 (KRAST) (envelope-from sa@nkz.delikates-nk.ru) Received: from nkz.delikates-nk.ru (localhost [127.0.0.1]) by nkz.delikates-nk.ru (8.13.6/8.13.6) with ESMTP id k7SBB2sU017578 for ; Mon, 28 Aug 2006 19:11:03 +0800 (KRAST) (envelope-from sa@nkz.delikates-nk.ru) Received: (from root@localhost) by nkz.delikates-nk.ru (8.13.6/8.13.6/Submit) id k7SBB1sF017577; Mon, 28 Aug 2006 19:11:01 +0800 (KRAST) (envelope-from sa) Message-Id: <200608281111.k7SBB1sF017577@nkz.delikates-nk.ru> Date: Mon, 28 Aug 2006 19:11:01 +0800 (KRAST) From: Eugene Grosbein To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/102600: [patch] ports/net-mgmt/arpwatch's rcNG script does not handle 'restart' X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Aug 2006 11:20:44 -0000 >Number: 102600 >Category: ports >Synopsis: [patch] ports/net-mgmt/arpwatch's rcNG script does not handle 'restart' >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Aug 28 11:20:22 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Eugene Grosbein >Release: FreeBSD 6.1-STABLE i386 >Organization: Svyaz Service JSC >Environment: System: FreeBSD nkz.delikates-nk.ru 6.1-STABLE FreeBSD 6.1-STABLE #0: Wed Aug 16 20:09:18 KRAST 2006 sa@nkz.delikates-nk.ru:/home/obj/home/src/sys/NKZ i386 >Description: ports/net-mgmt/arpwatch installs rc.NG script that does not analyze 'arpwatch_interfaces' parameter during restart and restartd arpwatch without needed arguments. Second, it sets 'pidfile' variable but arpwatch does not create one. >How-To-Repeat: echo arpwatch_enable=YES >> /etc/rc.conf echo arpwatch_interfaces=xl0 >> /etc/rc.conf echo 'arpwatch_xl0_options="-m arpwatch"' >> /etc/rc.conf /usr/local/etc/rc.d/arpwatch start This starts arpwatch OK. /usr/local/etc/rc.d/arpwatch restart This restarts arpwatch without command line arguments. >Fix: This should be applied to ports/net-mgmt/arpwatch directory. --- files/arpwatch.sh.in.orig Mon Aug 28 17:38:19 2006 +++ files/arpwatch.sh.in Mon Aug 28 17:38:43 2006 @@ -63,11 +63,10 @@ ;; *) - if [ "$1" = "start" ]; then + if [ "$1" = "start" -o "$1" = "restart" ]; then for interface in ${arpwatch_interfaces}; do eval options=\$arpwatch_${interface}_options command_args="-i ${interface} ${options} -f arp.${interface}.dat" - pidfile="/var/run/arpwatch-${interface}.pid" run_rc_command "$1" done else >Release-Note: >Audit-Trail: >Unformatted: