From owner-freebsd-qa@FreeBSD.ORG Wed Oct 1 16:58:22 2003 Return-Path: Delivered-To: freebsd-qa@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44E6D16A4B3; Wed, 1 Oct 2003 16:58:22 -0700 (PDT) Received: from alcanet.com.au (mail2.alcanet.com.au [203.62.196.17]) by mx1.FreeBSD.org (Postfix) with ESMTP id 512F743FD7; Wed, 1 Oct 2003 16:58:17 -0700 (PDT) (envelope-from peter.jeremy@alcatel.com.au) Received: from sydsmtp02.alcatel.com.au (IDENT:root@localhost.localdomain [127.0.0.1])h91NwB26003589; Thu, 2 Oct 2003 09:58:11 +1000 Received: from gsmx07.alcatel.com.au ([139.188.20.247]) by sydsmtp02.alcatel.com.au (Lotus Domino Release 5.0.12) with ESMTP id 2003100209581085:17458 ; Thu, 2 Oct 2003 09:58:10 +1000 Received: from gsmx07.alcatel.com.au (localhost [127.0.0.1]) by gsmx07.alcatel.com.au (8.12.9/8.12.9) with ESMTP id h91NwA7d058438; Thu, 2 Oct 2003 09:58:10 +1000 (EST) (envelope-from peter.jeremy@alcatel.com.au) Received: (from jeremyp@localhost) by gsmx07.alcatel.com.au (8.12.9/8.12.9/Submit) id h91NwAEV058437; Thu, 2 Oct 2003 09:58:10 +1000 (EST) (envelope-from peter.jeremy@alcatel.com.au) Date: Thu, 2 Oct 2003 09:58:10 +1000 From: Peter Jeremy To: Murray Stokely , stable@freebsd.org, qa@freebsd.org Message-ID: <20031001235809.GY91404@gsmx07.alcatel.com.au> Mail-Followup-To: Murray Stokely , stable@freebsd.org, qa@freebsd.org References: <20030929151905.GD3743@freebsdmall.com> <20030929160905.GB42388@falcon.midgard.homeip.net> Mime-Version: 1.0 In-Reply-To: <20030929160905.GB42388@falcon.midgard.homeip.net> User-Agent: Mutt/1.4.1i X-MIMETrack: Itemize by SMTP Server on SYDSMTP02/AlcatelAustralia(Release 5.0.12 |February 13, 2003) at 02/10/2003 09:58:10 AM,|February 13, 2003) at 02/10/2003 09:58:11 AM, Serialize complete at 02/10/2003 09:58:11 AM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: Re: FreeBSD 4.9 RC1 (i386) now available X-BeenThere: freebsd-qa@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD Quality Assurance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Oct 2003 23:58:22 -0000 On 2003-Sep-29 18:09:05 +0200, Erik Trulsson wrote: >On Mon, Sep 29, 2003 at 08:19:05AM -0700, Murray Stokely wrote: >> Not all FTP sites have the first release candidate, but it is at least >> available from ftp.freebsd.org. Please download and install this >> candidate and help us find bugs BEFORE we call it 4.9-RELEASE. > > >You mean apart from the minor bug that non-pci kernels using ata won't even >compile, and hasn't worked for the last three weeks or so? > > >See > >http://docs.freebsd.org/cgi/getmsg.cgi?fetch=44649+0+archive/2003/freebsd-stable/20030928.freebsd-stable > >or > >http://docs.freebsd.org/cgi/getmsg.cgi?fetch=816008+0+archive/2003/cvs-all/20030921.cvs-all > >for details and a patch. Whilst both Erik and I independently came up with the same patch, upon reflection, I'm not sure that this is the correct patch. None of the callers to ata_dmastart() check for a return value and therefore this probably should be a void function - so the code in ata-isa.c is correct and the remaining declaration and definitions are incorrect. In either case, I would request that this be fixed before 4.9-RELEASE. Peter