From owner-freebsd-current@freebsd.org Sun Dec 29 06:42:40 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 39CBA1D65D3 for ; Sun, 29 Dec 2019 06:42:40 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from jax4mhob02.myregisteredsite.com (jax4mhob02.myregisteredsite.com [64.69.218.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.registeredsite.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47lrbM1MMBz4C40 for ; Sun, 29 Dec 2019 06:42:38 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from mailpod.hostingplatform.com (atl4qobmail01pod2.registeredsite.com [10.30.77.35]) by jax4mhob02.myregisteredsite.com (8.14.4/8.14.4) with ESMTP id xBT6gaoE014481 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Sun, 29 Dec 2019 01:42:37 -0500 Received: (qmail 18010 invoked by uid 0); 29 Dec 2019 06:42:36 -0000 X-TCPREMOTEIP: 99.253.169.68 X-Authenticated-UID: dclarke@blastwave.org Received: from unknown (HELO ?172.16.35.2?) (dclarke@blastwave.org@99.253.169.68) by 0 with ESMTPA; 29 Dec 2019 06:42:36 -0000 Subject: Re: getting rid of sys/nfs/nfs_lock.c To: freebsd-current@freebsd.org References: From: Dennis Clarke Message-ID: <663f9bf2-c556-109f-dfdb-5eeb00fc0c2e@blastwave.org> Date: Sun, 29 Dec 2019 01:42:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:72.0) Gecko/20100101 Thunderbird/72.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47lrbM1MMBz4C40 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of dclarke@blastwave.org has no SPF policy when checking 64.69.218.82) smtp.mailfrom=dclarke@blastwave.org X-Spamd-Result: default: False [0.84 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-0.33)[-0.329,0]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.03)[-0.029,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[82.218.69.64.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; DMARC_NA(0.00)[blastwave.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:19871, ipnet:64.69.218.0/23, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.30)[ipnet: 64.69.218.0/23(-0.12), asn: 19871(1.67), country: US(-0.05)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 06:42:40 -0000 On 12/28/19 7:30 PM, Rick Macklem wrote: > Hi, > > sys/nfs/nfs_lock.c uses Giant. Since it has not been used by default since > March 2008, I suspect it can be removed from head without any impact. > Post March 2008, the only way this code could be executed is by both > building a kernel without "options NFSLOCKD" and deleting nfslockd.ko > from the kernel boot directory and then running rpc.lockd on the system. > > I doubt anyone has been doing both of the above, but if you think it is > still useful, please speak up. (I have an untested patch that replaces Giant > with a regular mutex. I realized this code is not used when I trying to test it.;-) > > Also, if it seems appropriate, I could commit a patch that makes it print out > "deprecated and going away before FreeBSD 13" message, but I doubt anyone > will ever see it. > Should I do such a message and wait a few months for the deletion? Such a message is a good idea. I am curious if there is any way in which we would see that message when creating an NFS share via ZFS set sharenfs='foo' ? -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional