From owner-freebsd-ports@FreeBSD.ORG Wed Dec 19 19:35:30 2007 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0558316A419; Wed, 19 Dec 2007 19:35:30 +0000 (UTC) (envelope-from beech@freebsd.org) Received: from freebsd.alaskaparadise.com (freebsd.alaskaparadise.com [208.79.80.117]) by mx1.freebsd.org (Postfix) with ESMTP id D32C913C45D; Wed, 19 Dec 2007 19:35:29 +0000 (UTC) (envelope-from beech@freebsd.org) Received: from 137-42-178-69.gci.net (137-42-178-69.gci.net [69.178.42.137]) by freebsd.alaskaparadise.com (Postfix) with ESMTP id 77CD52383595; Wed, 19 Dec 2007 19:35:28 +0000 (UTC) From: Beech Rintoul To: freebsd-ports@freebsd.org Date: Wed, 19 Dec 2007 10:35:19 -0900 User-Agent: KMail/1.9.7 References: <000f01c8422b$3515d7b0$c5010c0a@SUNYA> <006501c8424b$975d8c90$c5010c0a@SUNYA> <20071219144511.GA15338@eos.sc1.parodius.com> In-Reply-To: <20071219144511.GA15338@eos.sc1.parodius.com> X-Face: jC2w\k*Q1\0DA2Q0Eh&BrP/Rt2M,^2O#R07VoT98m*>miQF9%Bi9vy`F6cPjwEe?m,)=?utf-8?q?2=0A=09X=3FM=5C=3AOE9QgZ?="xT3/n3,3MJ7N=Cfkmi%f(w^~X"SUxn>; 27NO; C+)g[7J`$G*SN>{<=?utf-8?q?O=3Bg7=7C=0A=09o=7D=265A=5D4?=@7D`=Eb@Zs1Ln814?]|k@'bG=.Ca"[|8+_.OsNAo8!#?4u MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200712191035.24159.beech@freebsd.org> Cc: hiromi@tac.tsukuba.ac.jp, Jeremy Chadwick , Barry Byrne , perky@freebsd.org Subject: Re: FreeBSD Port: horde-base-3.1.5_1 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Beech Rintoul List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2007 19:35:30 -0000 On Wednesday 19 December 2007, Jeremy Chadwick said: > On Wed, Dec 19, 2007 at 02:29:40PM -0000, Barry Byrne wrote: > > > -----Original Message----- > > > From: Jeremy Chadwick [mailto:koitsu@FreeBSD.org] > > > Sent: 19 December 2007 11:34 > > > To: Barry Byrne > > > Cc: beech@FreeBSD.org; ports@FreeBSD.org; > > > hiromi@tac.tsukuba.ac.jp; ache@freebsd.org; perky@freebsd.org > > > > > > > Checked the patched file (NLS.php) and I had something like > > > > this; > > > > > > > > \xa0 \xa0 \xa0 \xa0/* avoid FreeBSD issapce(3) bug */ > > > > \xa0 \xa0 \xa0 \xa0if(NLS::getCharset() == "UTF-8"){ > > > > \xa0 \xa0 \xa0 \xa0 \xa0 \xa0setlocale(LC_CTYPE,"C"); > > > > \xa0 \xa0 \xa0 \xa0} > > > > > > > > When I replaced the \xa0 with tabs, all was fine again. > > > > > > The parse error is probably because PHP does not have Unicode > > > or multibyte character support enabled. The patch file in > > > question contains actual Unicode characters. You might try > > > rebuilding PHP with Zend support for multibyte characters (it's > > > an option in "make config") > > > and see if that improves things. > > > > Jeremy, > > > > Thanks for the quick response. > > > > You're correct in assuming I don't have Multibyte enabled. > > > > However, I just rebuilt php on another machine and enabled > > multibyte, then built horde-base on that, but still had the same > > characters in the NLS.php file on that, so not sure what the > > problem is. > > Okay, so it's probably a Unicode vs. UTF-8 parser thing. > > My comment about the code needing to remain in ASCII stands, though > (this isn't your fault, of course). The patch should really be > fixed to use literal whitespace (ASCII 0x20) or tabs (ASCII 0x09). > > I have commit access to fix this, but I want to clear it + discuss > with those involved with the PR first. I have re-rolled the patch, please let me know if you still have problems. It may take a while to get into the tree. Beech -- --------------------------------------------------------------------------------------- Beech Rintoul - FreeBSD Developer - beech@FreeBSD.org /"\ ASCII Ribbon Campaign | FreeBSD Since 4.x \ / - NO HTML/RTF in e-mail | http://www.freebsd.org X - NO Word docs in e-mail | Latest Release: / \ - http://www.FreeBSD.org/releases/6.2R/announce.html ---------------------------------------------------------------------------------------