From nobody Mon Apr 27 03:24:08 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g3pnh254Xz6bbK7 for ; Mon, 27 Apr 2026 03:24:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g3pnh1NXGz3nWg for ; Mon, 27 Apr 2026 03:24:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777260248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J4vzSZlxy9i4LPvyFibz+F/Cq2NSz1OaLwdEMQc+0LI=; b=ABos5S/IEqqJqTZS+/qncsBIAQVMnqIXqf2FeLx5MkkIDQPPnD2RmRqe7iKxBk6kdBnR9w sHp8i2Az6qz+8qV6K0meAWwT0vN979QoBA/Me6CYCXYA2jOmbUz8zPX+rPNXGziI/jEyXF bFuZgx81hc2C0Qu5ZhYTSr9HB5p7L3gS36eLyfUrR4VbSI3LmWj096UhFAXvPwUeauywmY izgSWHdRrqrMBOjlqskVj6BBsB/os6fIhgoZmPHxkc1+KgzWgTF5Qmz7L+uqdA2JM3dS9X 925nvzN/B5UCP4afq2UNXR1Gf2tsg4wVa+XXMyL/GFO/4ZrzbwSOai0tOgfXaQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777260248; a=rsa-sha256; cv=none; b=j5w5RUPnhuU+23Xm0wBmFvNi8Pp8cTuXQVoH+BAR4K+BhW5WGUtbFtfVVI3+2oQi0mcULk cEoUbIyzsdDzkBZhptHQ0/a2n6gEe/6qn6Dag+su8V//ISxHfmrQ0+REVftOJ2BuMEVQsN s4sjzt4ZanVPD5ta1K0NAmDqsJGHwYs43g+QK5SEgPPkir0aMtqo3YAVZFEjjnefBnHQzk u3pXrJ7eDB1uadZDJK67PY9NidAz5bdjthmYQ5kI34j1ARbXfquLQIKkH+IgeNTTDk9KVk Gn7+MrVSDM5FsEH0FYsj/J4UFu8HQjeke3NWqexSGvQR/TrEQQeyx4xAuUE4vQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777260248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J4vzSZlxy9i4LPvyFibz+F/Cq2NSz1OaLwdEMQc+0LI=; b=smuDaaBvpVpAOZdHR9pA9mQB45GejSLF54v83QqRPskUoB/7bDrw6DrfC9kSjXYnEaRtEh C3Fgs9mTXSxZel8jwFYjlgsD/qCM/nRQFYeK4xWCRVqc9x3nwWGBF+WSGKicoxY6sWatZn 9ErD17xAA7NKdJIyvYD4GTBDh7BRnGzlkINIA3rgZQKsGBQ95UTIwVQoC8BUrlgQWXBBPU bSqQwJNIfufHLlw2GJ30+rEcHjAA4H4HSMitFp54RLCIOXs2RYXIyN8W+gHp4RYagrvwuV BPmT8U/eAK6bpMaF9asCXqfBz5qGQ9ThtuSPmwsda5OkWRgiHQjgB05szTKXmA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g3pnh0vZ7zqc6 for ; Mon, 27 Apr 2026 03:24:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3b67a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 27 Apr 2026 03:24:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 912f9dfca451 - main - amd64: ia32_fetch_syscall_args() does not need to check params != NULL List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 912f9dfca451e359dda7cdf45539b7c19764f54d Auto-Submitted: auto-generated Date: Mon, 27 Apr 2026 03:24:08 +0000 Message-Id: <69eed6d8.3b67a.1a6ed2c7@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=912f9dfca451e359dda7cdf45539b7c19764f54d commit 912f9dfca451e359dda7cdf45539b7c19764f54d Author: Konstantin Belousov AuthorDate: 2026-04-25 09:46:50 +0000 Commit: Konstantin Belousov CommitDate: 2026-04-27 03:23:19 +0000 amd64: ia32_fetch_syscall_args() does not need to check params != NULL Whatever params pointer is, it does not matter. copyin() handles any values. In fact, params cannot be ever NULL. Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D56630 --- sys/amd64/ia32/ia32_syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/amd64/ia32/ia32_syscall.c b/sys/amd64/ia32/ia32_syscall.c index c61587a93d1f..85e3d8f8e920 100644 --- a/sys/amd64/ia32/ia32_syscall.c +++ b/sys/amd64/ia32/ia32_syscall.c @@ -187,7 +187,7 @@ ia32_fetch_syscall_args(struct thread *td) else sa->callp = &p->p_sysent->sv_table[sa->code]; - if (params != NULL && sa->callp->sy_narg != 0) + if (sa->callp->sy_narg != 0) error = copyin(params, (caddr_t)args, (u_int)(sa->callp->sy_narg * sizeof(int))); else