From owner-svn-src-head@FreeBSD.ORG  Thu Nov 19 04:12:37 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5CD2D106566C;
	Thu, 19 Nov 2009 04:12:37 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 1D5378FC0A;
	Thu, 19 Nov 2009 04:12:37 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id nAJ46ZWi072500;
	Wed, 18 Nov 2009 21:06:35 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Wed, 18 Nov 2009 21:06:59 -0700 (MST)
Message-Id: <20091118.210659.63015724.imp@bsdimp.com>
To: davidxu@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <4B049B32.6090801@freebsd.org>
References: <200911180509.nAI593kQ058970@svn.freebsd.org>
	<20091118.072514.673374189.imp@bsdimp.com>
	<4B049B32.6090801@freebsd.org>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r199469 - head/lib/librt
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Nov 2009 04:12:37 -0000

In message: <4B049B32.6090801@freebsd.org>
            David Xu <davidxu@FreeBSD.org> writes:
: M. Warner Losh wrote:
: > In message: <200911180509.nAI593kQ058970@svn.freebsd.org>
: >             David Xu <davidxu@freebsd.org> writes:
: > : Author: davidxu
: > : Date: Wed Nov 18 05:09:03 2009
: > : New Revision: 199469
: > : URL: http://svn.freebsd.org/changeset/base/199469
: > : 
: > : Log:
: > :   link libpthread because the librt really needs it to fully function.
: > 
: > If you are now requiring libpthread, why are you using the _pthread_*
: > functions everywhere else?
: > 
: > Warner
: 
: now the pthread_cleanup_push is a macro, but originally it is a
: function.
: 
: I don't know if we need an underline version of pthread_cleanup_push,
: it is trivial if one wants to add it.

That makes sense.  won't we need some compat shim for old binaries?

Warner