From owner-freebsd-gnome@FreeBSD.ORG Thu Feb 26 18:27:06 2009 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A74EA10656ED; Thu, 26 Feb 2009 18:27:06 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from creme-brulee.marcuscom.com (marcuscom-pt.tunnel.tserv1.fmt.ipv6.he.net [IPv6:2001:470:1f00:ffff::1279]) by mx1.freebsd.org (Postfix) with ESMTP id 5553F8FC19; Thu, 26 Feb 2009 18:27:06 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from [IPv6:2001:470:1f00:2464::4] (shumai.marcuscom.com [IPv6:2001:470:1f00:2464::4]) by creme-brulee.marcuscom.com (8.14.3/8.14.3) with ESMTP id n1QISg1P024410; Thu, 26 Feb 2009 13:28:42 -0500 (EST) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: "Andrew W. Nosenko" In-Reply-To: <6161f3180902260653x2a6705l69b36c01b41caca0@mail.gmail.com> References: <20090224021026.ba40bdc2.stas@FreeBSD.org> <1235598615.3297.60.camel@shumai.marcuscom.com> <20090226171804.8681e79c.stas@FreeBSD.org> <6161f3180902260653x2a6705l69b36c01b41caca0@mail.gmail.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-znsWQRhZCUvDmGKzgtmf" Organization: MarcusCom, Inc. Date: Thu, 26 Feb 2009 13:27:27 -0500 Message-Id: <1235672847.3297.82.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.24.4 FreeBSD GNOME Team Port X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on creme-brulee.marcuscom.com Cc: Stanislav Sedov , gnome@freebsd.org Subject: Re: [FreeBSD port]: devel/glib20 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2009 18:27:07 -0000 --=-znsWQRhZCUvDmGKzgtmf Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2009-02-26 at 16:53 +0200, Andrew W. Nosenko wrote: > On Thu, Feb 26, 2009 at 4:18 PM, Stanislav Sedov wrote= : > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > On Wed, 25 Feb 2009 16:50:15 -0500 > > Joe Marcus Clarke mentioned: > > > >> On Tue, 2009-02-24 at 02:10 +0300, Stanislav Sedov wrote: > >> > -----BEGIN PGP SIGNED MESSAGE----- > >> > Hash: SHA1 > >> > > >> > Hi! > >> > > >> > glib20 has a known filename encoding problem with non-utf8 > >> > locales, because it doesn't perform names conversion from > >> > internal UTF8 to current locale by default (it used to do > >> > that some time ago). The patch included changes glib20 > >> > behaviour to always do the conversion (this will work > >> > for all non-UTF8 locales and will have no effect fot UTF8 > >> > ones). This is effectively the same redhat & co does in > >> > their deistributions. > >> > > >> > Comments? > >> > >> I have no objection, but I don't typically run into problems with > >> non-UTF-8 locales. I think it would be safer if you made this into an > >> OPTION, and added this as an extra patch if the OPTION is enabled. > >> > > > > Doesn't running gtk/glib (e.g. sylpheed, gimp) apps with non-UTF locale > > break filenames for you? From looking into the code it's always the cas= e > > for non-UTF locales (well, if you running ISO8859-1 you shouldn't have > > problems too). On the other hand enabling LANG-based locale detection s= hould > > not hurt prefromance much (I think the overhead of parsing LANG is negl= ible). > > Sure, we can OPTIONfy this, but I belive the options should be enabled = by > > default in this case (otherwise, people will continue to step onto this > > bug). Major Linux distributions also have this option turned on by defa= ult > > to match the behavior of older version of glib where the locale detecti= on > > code was always enabled. > > >=20 > Why you want to patch Glib for turn this behavior on by default > instead of just install file in the /usr/local/etc/profile.d ? Not everyone uses bash. >=20 > profile.d approrach is reversible (I can unset enviroment variable), > while patching Glib for remove patch ... slightly ugly at least, > IMHO. This is why I suggested to make it optional. Joe >=20 --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-znsWQRhZCUvDmGKzgtmf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkmm3w4ACgkQb2iPiv4Uz4d4/ACaAsr06D2QHl0X00FdZd9zKBYl jRAAoIxcxdA7ALRxVwZsGJVcXW0Vt+EK =uQKN -----END PGP SIGNATURE----- --=-znsWQRhZCUvDmGKzgtmf--