Date: Sat, 01 Sep 2018 16:33:25 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Tobias Kortkamp <tobik@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r478679 - head/devel/boost-python-libs Message-ID: <sh2t-qocq-wny@FreeBSD.org> References: <201809011239.w81CdN2E020942@repo.freebsd.org> <1535807532.607241.1493457672.6296710D@webmail.messagingengine.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Tobias Kortkamp <tobik@FreeBSD.org> writes: > On Sat, Sep 1, 2018, at 14:39, Jan Beich wrote: > >> Author: jbeich >> Date: Sat Sep 1 12:39:23 2018 >> New Revision: 478679 >> URL: https://svnweb.freebsd.org/changeset/ports/478679 >> >> Log: >> devel/boost-python-libs: unbreak in C++17 mode >> >> In file included from libs/python/src/converter/from_python.cpp:6: >> In file included from ./boost/python/converter/from_python.hpp:8: >> In file included from ./boost/python/detail/prefix.hpp:13: >> In file included from ./boost/python/detail/wrap_python.hpp:151: >> In file included from /usr/local/include/python2.7/Python.h:88: >> /usr/local/include/python2.7/unicodeobject.h:534:5: error: ISO C++17 >> does not allow 'register' storage class specifier [-Wregister] >> register PyObject *obj, /* Object */ >> ^~~~~~~~~ >> /usr/local/include/python2.7/unicodeobject.h:553:5: error: ISO C++17 >> does not allow 'register' storage class specifier [-Wregister] >> register PyObject *obj /* Object */ >> ^~~~~~~~~ >> /usr/local/include/python2.7/unicodeobject.h:575:5: error: ISO C++17 >> does not allow 'register' storage class specifier [-Wregister] >> register const wchar_t *w, /* wchar_t buffer */ >> ^~~~~~~~~ >> /usr/local/include/python2.7/unicodeobject.h:593:5: error: ISO C++17 >> does not allow 'register' storage class specifier [-Wregister] >> register wchar_t *w, /* wchar_t buffer */ >> ^~~~~~~~~ > > Should we just patch lang/python27 to remove 'register' here instead > of having to patch various ports now and in the future? AFAIUI > 'register' is quite useless nowadays. Maybe[1] but Clang is too pedantic about C++. -I vs. -isystem is a common issue many projects ignore, not just due to warnings in dependencies but also include order (e.g., bug 159831, 193187). boost-python-libs doesn't call python2.7-config --cflags, so it probably cannot blame python27 for using -I. [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231073
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?sh2t-qocq-wny>