From owner-svn-src-all@freebsd.org Mon Jul 18 16:19:36 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C0085B9DDF7 for ; Mon, 18 Jul 2016 16:19:36 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 86BC21F72 for ; Mon, 18 Jul 2016 16:19:36 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-io0-x234.google.com with SMTP id m101so163836436ioi.2 for ; Mon, 18 Jul 2016 09:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Fb1z4EzxM5VPUnvWqeiYOEor6VbgTwpPIsxUs3j8IRc=; b=p3EfKBxlUV6ZyuVOrwHJ02e3H+CnzdFVBznpa5LBg8DG3dMBlP+PUO5DV3ngYxjJ4r p/NIG11M/H3B0xIWklc+D0jtU0PUgTUm2CcWCZ63FnS+Czp/yPzLj4h520t6p4NASRGG eZGi4mFfqyM9d0gu5CRRMeyWhocY8Rx1bPpbM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Fb1z4EzxM5VPUnvWqeiYOEor6VbgTwpPIsxUs3j8IRc=; b=mWfr7gcV5mlEPAhDTH3ACYlBkPhgHSLi7YnfNLP4+b0MMO/BCKM6xbsEugm7Wh4vmg /ErtYFIr4jmza4Aq/qU3EzURCQ2SH2OQ0jmPOypr+GLDO4vjzBzq06JscVwPtqe/jYXS 02er3O36a5P5BGtJH1PYWODJ/+uE7tUp8C1ld9NUiolrTHehthj+nM4sjBR4Qr/DpOeD 2531Vqq67Hfnbfhjz2ejWaEuGY78lOfF5MwO9MaV40PZNzjDEVRVthLH47YLZuX4sEkW mvs32z7V4zm/YayziCfH9hPQxJuh29uOUK7iOSFG+mIJnVISAKmhtUckRk9xVufa+/df Ip2Q== X-Gm-Message-State: ALyK8tI9b8BZrA/rd45FjYNuqKQi8Ob46gXarb5heSx27VWrygUru9y/tiVKU/w5Tzc8k6v2 X-Received: by 10.107.22.6 with SMTP id 6mr34463967iow.128.1468858775780; Mon, 18 Jul 2016 09:19:35 -0700 (PDT) Received: from [100.127.65.10] ([69.53.245.200]) by smtp.gmail.com with ESMTPSA id u7sm4903209ita.21.2016.07.18.09.19.33 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Jul 2016 09:19:35 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r302998 - head/sys/kern From: Randall Stewart In-Reply-To: <64C1543A-3EDE-4852-88EA-5B0B78FCF016@netflix.com> Date: Mon, 18 Jul 2016 18:19:31 +0200 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <58868615-8255-4D8B-BD9E-8E19A734CB6C@netflix.com> References: <201607180929.u6I9T9Uw063705@repo.freebsd.org> <64C1543A-3EDE-4852-88EA-5B0B78FCF016@netflix.com> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2016 16:19:36 -0000 I have worked out a fix of this in Netflix code base (I have the same = code running there). I will get that tested tonight I will get the fixes in to restore the = behavior. I will setup a phabricator shortly.. most likely I will update the one I = already have on the one problem your earlier patch did not fix. R > On Jul 18, 2016, at 5:44 PM, Randall Stewart wrote: >=20 > Gleb: >=20 > This now leaks TCP-PCB=E2=80=99s since you have broken the return = codes with all your > fixes that used to be in here. >=20 > It was >=20 > return 1 =E2=80=94 You stopped the callout > return 0 =E2=80=94 The callout could not be stopped > return -1 =E2=80=94 The callout was not running. >=20 > The LLRef code that was crashing in in.c depended on this to know to = free > the memory.. i.e. if was > 0 then they needed to free the memory. >=20 > TCP depends on a return 0 to indicate the async-drain function will be = called back and > thus increments a refcnt and waits for the callback. >=20 > You now return 0 when no timer was active.. which makes the stack then = wait > for the not forth coming async-drain call. >=20 > R >> On Jul 18, 2016, at 11:29 AM, Gleb Smirnoff = wrote: >>=20 >> Author: glebius >> Date: Mon Jul 18 09:29:08 2016 >> New Revision: 302998 >> URL: https://svnweb.freebsd.org/changeset/base/302998 >>=20 >> Log: >> Revert the last commit. It must get more review and testing first. >>=20 >> Modified: >> head/sys/kern/kern_timeout.c >>=20 >> Modified: head/sys/kern/kern_timeout.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/kern/kern_timeout.c Mon Jul 18 09:26:06 2016 = (r302997) >> +++ head/sys/kern/kern_timeout.c Mon Jul 18 09:29:08 2016 = (r302998) >> @@ -1381,7 +1381,7 @@ again: >> CTR3(KTR_CALLOUT, "failed to stop %p func %p arg %p", >> c, c->c_func, c->c_arg); >> CC_UNLOCK(cc); >> - return (-1); >> + return (0); >> } >>=20 >> c->c_iflags &=3D ~CALLOUT_PENDING; >>=20 >=20 > -------- > Randall Stewart > rrs@netflix.com > 803-317-4952 >=20 >=20 >=20 >=20 >=20 -------- Randall Stewart rrs@netflix.com 803-317-4952