Date: Thu, 14 Mar 2013 17:47:13 +0100 From: Andre Oppermann <andre@freebsd.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r248269 - user/andre/tcp-ao/sys/netinet Message-ID: <5141FF11.3000504@freebsd.org> In-Reply-To: <20130314162933.GG48089@FreeBSD.org> References: <201303141627.r2EGR2gA033139@svn.freebsd.org> <20130314162933.GG48089@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14.03.2013 17:29, Gleb Smirnoff wrote: > Andre, > > On Thu, Mar 14, 2013 at 04:27:02PM +0000, Andre Oppermann wrote: > A> Author: andre > A> Date: Thu Mar 14 16:27:01 2013 > A> New Revision: 248269 > A> URL: http://svnweb.freebsd.org/changeset/base/248269 > A> > A> Log: > A> Add IPv6 pseudo header for use in checksum calculations. > > Why obsoleted u_intXX_t instead of uintXX_t in new code? Legacy style of surrounding code. What's our policy there? I tend to keep it the same. Changes like this not directly related to TCP-AO will be committed separately to HEAD. -- Andre > A> Sponsored by: Juniper Networks > A> > A> Modified: > A> user/andre/tcp-ao/sys/netinet/ip6.h > A> > A> Modified: user/andre/tcp-ao/sys/netinet/ip6.h > A> ============================================================================== > A> --- user/andre/tcp-ao/sys/netinet/ip6.h Thu Mar 14 16:24:50 2013 (r248268) > A> +++ user/andre/tcp-ao/sys/netinet/ip6.h Thu Mar 14 16:27:01 2013 (r248269) > A> @@ -248,6 +248,18 @@ struct ip6_frag { > A> #endif /* BYTE_ORDER == LITTLE_ENDIAN */ > A> > A> /* > A> + * This is the real IPv6 pseudo header, used for computing the TCP and UDP > A> + * checksums. > A> + */ > A> +struct ip6pseudo { > A> + struct in6_addr ip6pseudo_src; /* source internet address */ > A> + struct in6_addr ip6pseudo_dst; /* destination internet address */ > A> + u_int32_t ip6pseudo_len; /* payload length */ > A> + u_int16_t ip6pseudo_pad; /* padding (zero) */ > A> + u_int16_t ip6pseudo_p; /* next-header (protocol) */ > A> +}; > A> + > A> +/* > A> * Internet implementation parameters. > A> */ > A> #define IPV6_MAXHLIM 255 /* maximum hoplimit */ >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5141FF11.3000504>