From owner-freebsd-current@FreeBSD.ORG Mon Nov 19 12:42:46 2007 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9DD0F16A419; Mon, 19 Nov 2007 12:42:46 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 7BBE013C468; Mon, 19 Nov 2007 12:42:46 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 65DCF47460; Mon, 19 Nov 2007 07:45:04 -0500 (EST) Date: Mon, 19 Nov 2007 12:42:30 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Adam McDougall In-Reply-To: <20071117162620.GR46369@egr.msu.edu> Message-ID: <20071119124156.G59049@fledge.watson.org> References: <698405.85667.qm@web31809.mail.mud.yahoo.com> <20071116143239.U10677@fledge.watson.org> <20071116164549.GF37473@egr.msu.edu> <20071117162620.GR46369@egr.msu.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Timo Sirainen , freebsd-current@FreeBSD.org, Mohan Srinivasan , mohans@FreeBSD.org Subject: Re: link() not increasing link count on NFS server X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2007 12:42:46 -0000 On Sat, 17 Nov 2007, Adam McDougall wrote: > On Fri, Nov 16, 2007 at 11:45:49AM -0500, Adam McDougall wrote: > > On Fri, Nov 16, 2007 at 02:37:56PM +0000, Robert Watson wrote: > > OK, I've attached an initial patch that does this -- we still need to > keep > the lookup code for NFSv2, where the file handle of the new node isn't > returned with the reply, but I drop the EEXIST handling cases. Does this > look reasonable to you? I'm not set up to easily test this scenario, > however. > > Robert N M Watson > > I should be able to test this patch (or a later version) this weekend. > > Seems to work. I ran the original test case for several minutes without > error for over 2000 iterations. I only tested it on -stable by applying the > patch manually. If it is required I test it verbatim on 7, let me know and > I will. Thanks. This sounds good, I will go ahead and merge it to HEAD, then start on the MFC cycle. Thanks, Robert N M Watson Computer Laboratory University of Cambridge