From owner-freebsd-wireless@FreeBSD.ORG Tue Feb 14 16:03:20 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 85D9F1065740 for ; Tue, 14 Feb 2012 16:03:20 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-lpp01m020-f182.google.com (mail-lpp01m020-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 0288D8FC1E for ; Tue, 14 Feb 2012 16:03:19 +0000 (UTC) Received: by lbbgj3 with SMTP id gj3so4688797lbb.13 for ; Tue, 14 Feb 2012 08:03:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=4X+Bk6HPnwplzxEdfQuy5b3Snk5nMpDK+LWSo350AF4=; b=niiIsrfSuS866nuGzwVgB2wtCUIcaufTTYTXw6YPqGdLNUvI88+mrz2hdTMB18SIsn E9JxkH1e96QsKgDNGs1OJ7XMQu5QdzdXdVplSAk5jIC3tzrij7D1IkQNU9A6dUUk7e1j YQ0WgcEbTrttbmvAt9Pb0Lc8Molk/KvLTLgkQ= MIME-Version: 1.0 Received: by 10.152.125.20 with SMTP id mm20mr14562389lab.6.1329235398702; Tue, 14 Feb 2012 08:03:18 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.112.87.35 with HTTP; Tue, 14 Feb 2012 08:03:18 -0800 (PST) In-Reply-To: References: Date: Tue, 14 Feb 2012 08:03:18 -0800 X-Google-Sender-Auth: R_qqgYSwWScon42SFEEGH1wbbtk Message-ID: From: Adrian Chadd To: Monthadar Al Jaberi Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-wireless@freebsd.org Subject: Re: Fragment number of first fragment != 0 X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Feb 2012 16:03:20 -0000 .. I think the answer is "yes". Please create a PR with what you've put in this email and a patch to fix it. I'll commit that fix today :0 adrian On 14 February 2012 00:26, Adrian Chadd wrote: > Lemme check into this a little more.. > > > adrian > > On 14 February 2012 00:19, Monthadar Al Jaberi wrote: >> Hi, >> >> I found that in FreeBSD current the first fragment will have a >> fragment number = 1 in function ieee80211_fragment. >> >> But according to 802.11-2007, 9.4 Fragmentation page 279: >> "...The fragments shall be sent in order of lowest fragment number to >> highest fragment >> number, where the fragment number value starts at zero, ..." >> >> This also holds on the 802.11-2011 draft 12: >> "The fragment number is set to 0 in the first or only fragment of an >> MSDU or MMPDU and is >> incremented by one for each successive fragment of that MSDU or MMPDU." >> >> I checked Linux 3.3-rc3 code and there I see them having a check on rx side >> if (frag == 0) { /* This is the first fragment of a new frame. */ >> and on tx side they put: >> fragnum = 0; >> >> On Madwifi 0.9.4 in function ieee80211_encap: >> fragnum = 0; >> >> So should we change our fragno to be 0? >> >> br, >> >> -- >> Monthadar Al Jaberi >> _______________________________________________ >> freebsd-wireless@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-wireless >> To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.org"