From owner-freebsd-current@FreeBSD.ORG Tue Jun 9 14:58:50 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2DD68106566B; Tue, 9 Jun 2009 14:58:50 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195]) by mx1.freebsd.org (Postfix) with ESMTP id DEF0C8FC13; Tue, 9 Jun 2009 14:58:49 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from [192.168.1.4] (adsl-157-59-252.bna.bellsouth.net [70.157.59.252]) (authenticated bits=0) by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id n59EwlFY033843 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 9 Jun 2009 10:58:48 -0400 (EDT) (envelope-from rnoland@FreeBSD.org) From: Robert Noland To: Yuri Pankov In-Reply-To: <20090609135145.GB1290@darklight.homeunix.org> References: <20090609110540.GA1290@darklight.homeunix.org> <200906090937.37562.jhb@freebsd.org> <20090609135145.GB1290@darklight.homeunix.org> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-j41x/m41vTb4TUgX+U43" Organization: FreeBSD Date: Tue, 09 Jun 2009 09:58:42 -0500 Message-Id: <1244559522.60347.1591.camel@balrog.2hip.net> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 FreeBSD GNOME Team Port X-Spam-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_PBL, RDNS_DYNAMIC,SPF_SOFTFAIL autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net Cc: freebsd-current@freebsd.org, ps@FreeBSD.org Subject: Re: panic: knlist not locked, but should be X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2009 14:58:50 -0000 --=-j41x/m41vTb4TUgX+U43 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2009-06-09 at 17:51 +0400, Yuri Pankov wrote: > On Tue, Jun 09, 2009 at 09:37:37AM -0400, John Baldwin wrote: > > On Tuesday 09 June 2009 7:05:40 am Yuri Pankov wrote: > > > Hi, > > >=20 > > > I'm getting the following panic when running Firefox+nspluginwrapper > > > (which crashes a lot, but paniced the box only two times, if it's eve= n > > > related). -CURRENT/amd64 20080607. > > >=20 > > > Unread portion of the kernel message buffer: > > > panic: knlist not locked, but should be > > > cpuid =3D 0 > > > KDB: stack backtrace: > > > db_trace_self_wrapper() at db_trace_self_wrapper+0x2a > > > panic() at panic+0x182 > > > knote() at knote+0xea > > > VOP_WRITE_APV() at VOP_WRITE_APV+0x152 > > > vn_rdwr() at vn_rdwr+0x21d > > > vn_rdwr_inchunks() at vn_rdwr_inchunks+0xc2 > > > elf32_coredump() at elf32_coredump+0x109 > > > sigexit() at sigexit+0x810 > > > postsig() at postsig+0x32f > > > ast() at ast+0x3ac > > > doreti_ast() at doreti_ast+0x1f > >=20 > > Are you using ZFS? > >=20 > > --=20 > > John Baldwin >=20 > Yes, sorry for not mentioning it. >=20 Ok, with guidance from jhb@ I applied the following patch, which resolves the panic. I do still get a LOR though. He suggested that ps@ is probably the right place for this to go, cc'ed. In my case, I have a desktop image downloaded to the desktop which is causing issues for tracker-extract. When tracker-extract explodes it triggers the panic. Index: contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c (revision 193531) +++ contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c (working copy) @@ -573,7 +573,7 @@ vfsp->mnt_flag |=3D MNT_LOCAL; vfsp->mnt_kern_flag |=3D MNTK_MPSAFE; vfsp->mnt_kern_flag |=3D MNTK_LOOKUP_SHARED; - vfsp->mnt_kern_flag |=3D MNTK_SHARED_WRITES; +// vfsp->mnt_kern_flag |=3D MNTK_SHARED_WRITES; =20 if (error =3D dsl_prop_get_integer(osname, "readonly", &readonly, NULL)) goto out; lock order reversal: 1st 0xffffff00490c0848 filedesc structure (filedesc structure) @ /usr/src/sys/kern/kern_descrip.c:1088 2nd 0xffffff00523339d0 zfs (zfs) @ /usr/src/sys/kern/vfs_subr.c:4091 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2a _witness_debugger() at _witness_debugger+0x2e witness_checkorder() at witness_checkorder+0x81e __lockmgr_args() at __lockmgr_args+0xc2a vop_stdlock() at vop_stdlock+0x39 VOP_LOCK1_APV() at VOP_LOCK1_APV+0xbf _vn_lock() at _vn_lock+0x47 knlist_remove_kq() at knlist_remove_kq+0x73 knote_fdclose() at knote_fdclose+0x177 kern_close() at kern_close+0xe9 syscall() at syscall+0x1dd Xfast_syscall() at Xfast_syscall+0xd0 --- syscall (6, FreeBSD ELF64, close), rip =3D 0x800e4242c, rsp =3D 0x7fffffffe548, rbp =3D 0x80107ecd0 --- robert. > Yuri > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org= " --=20 Robert Noland FreeBSD --=-j41x/m41vTb4TUgX+U43 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEABECAAYFAkoueKIACgkQM4TrQ4qfROMHLgCffl+6Lkp/b+ZpH9THl9XiOOd5 gqsAoIYsjduXobJE8GXuKUE6VbcCQm2o =nb8k -----END PGP SIGNATURE----- --=-j41x/m41vTb4TUgX+U43--