From owner-freebsd-current@FreeBSD.ORG Fri Aug 1 22:21:19 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AF5AD4E1 for ; Fri, 1 Aug 2014 22:21:19 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "funkthat.com", Issuer "funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 8A2B72078 for ; Fri, 1 Aug 2014 22:21:19 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id s71MLI3e054376 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 1 Aug 2014 15:21:18 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id s71MLImm054375; Fri, 1 Aug 2014 15:21:18 -0700 (PDT) (envelope-from jmg) Date: Fri, 1 Aug 2014 15:21:18 -0700 From: John-Mark Gurney To: Svatopluk Kraus Subject: Re: domain_add(xxx) after domainfinalize... Message-ID: <20140801222118.GH50495@funkthat.com> Mail-Followup-To: Svatopluk Kraus , freebsd-current@freebsd.org References: <20140801193403.GE50495@funkthat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Fri, 01 Aug 2014 15:21:18 -0700 (PDT) Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2014 22:21:19 -0000 Svatopluk Kraus wrote this message on Sat, Aug 02, 2014 at 00:05 +0200: > Just what I've got in January 2011: > http://lists.freebsd.org/pipermail/freebsd-hackers/2011-January/034037.html Sadly, after three (or six+) years, it is clear that these bugs will not be fixed, and this warning message is not useful, since no one has stepped up to fix them.. btw, you might want to create a bug w/ the information you tracked down to hopefully help the person that decides to finally fix them, though I doubt they will ever be fixed as people apparently don't see bad behavior... Unless someone fixes the bugs in the next few days, I will commit the following patch: Index: uipc_domain.c =================================================================== --- uipc_domain.c (revision 266964) +++ uipc_domain.c (working copy) @@ -227,15 +227,10 @@ printf("WARNING: attempt to domain_add(%s) before " "domaininit()\n", dp->dom_name); #endif -#ifdef notyet - KASSERT(domain_init_status < 2, - ("attempt to domain_add(%s) after domainfinalize()", - dp->dom_name)); -#else - if (domain_init_status >= 2) - printf("WARNING: attempt to domain_add(%s) after " - "domainfinalize()\n", dp->dom_name); -#endif + /* + * XXX - there are bugs WRT to adding domain after domain_finalize is + * called + */ mtx_unlock(&dom_mtx); } > On Fri, Aug 1, 2014 at 9:34 PM, John-Mark Gurney wrote: > > > So, I have a laptop that devd loads the bluetooth module every time.. > > > > This means I get the following error on every boot: > > WARNING: attempt to domain_add(bluetooth) after domainfinalize() > > WARNING: attempt to domain_add(netgraph) after domainfinalize() > > > > Is there any real benefit to this warning? I just looked at the code, > > and the domain gets added despite the warning... > > > > Also, it looks like the pervious warning, we should just make that an > > if/panic since it's clearly a programming bug, or kill the ifndef > > INVARIANTS... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."