From owner-svn-ports-all@FreeBSD.ORG  Wed Jul 30 16:14:29 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 457F6898;
 Wed, 30 Jul 2014 16:14:29 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 16AB3245C;
 Wed, 30 Jul 2014 16:14:28 +0000 (UTC)
Received: from [192.168.0.21] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 0CE5943BA8;
 Wed, 30 Jul 2014 11:14:06 -0500 (CDT)
Message-ID: <53D919BC.6010307@marino.st>
Date: Wed, 30 Jul 2014 18:13:48 +0200
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>, 
 Mathieu Arnold <mat@FreeBSD.org>
Subject: Re: svn commit: r363361 - in head/editors/fte: . files
References: <201407291646.s6TGkjHH090335@svn.freebsd.org>
 <41D25BC1-AC62-4280-A342-8A2BDD84B1E0@adamw.org>
 <20140730070412.GA97692@FreeBSD.org>
 <3898057.T8DsoXnEEp@mercury.ph.man.ac.uk> <53D89EBF.4080805@marino.st>
 <2D24420529C9ECAEABB9A791@atuin.in.mat.cc> <53D8A2BB.7090704@marino.st>
 <6270029E710D3C52B60B6224@atuin.in.mat.cc>
 <20140730081413.GA29876@FreeBSD.org> <20140730160843.GA2688@FreeBSD.org>
In-Reply-To: <20140730160843.GA2688@FreeBSD.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, Max Brazhnikov <makc@freebsd.org>,
 svn-ports-all@freebsd.org, marino@freebsd.org,
 William Grzybowski <wg@freebsd.org>, ports-committers@freebsd.org,
 Adam Weinberger <adamw@adamw.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jul 2014 16:14:29 -0000

On 7/30/2014 18:08, Alexey Dokuchaev wrote:
> On Wed, Jul 30, 2014 at 08:14:14AM +0000, Alexey Dokuchaev wrote:
>> On Wed, Jul 30, 2014 at 10:08:05AM +0200, Mathieu Arnold wrote:
>>> But, I think you're missing the point, who cares what the separator is ?
>>> All it needs to do is work when I run make patch. Also, all one needs to
>>> know is that to generate the patches, you run make makepatch.
>>
>> Well, if you don't care, then I guess you won't mind if we change it to
>> something more appealing to those who do care.
> 
> Given some thought over it, I propose the following changes to makepatch:
> 
>   - default to dash (minus, '-')
>   - provide a command line option (-s?) or make(1) variable (PATH_SEPARATOR)
>     to override it when needed
>   - assert that forced value is not something insane ('__', '::', '../../',
>     etc.) -- basically, match it over a prerefined list of acceptable values
> 
> I can cook up a patch unless John had beaten me on that already.
> 

Nope, go for it.
John