From owner-freebsd-bugs@FreeBSD.ORG  Sun Mar 11 19:10:14 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B4D6F1065675
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 11 Mar 2012 19:10:14 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 74B178FC1D
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 11 Mar 2012 19:10:14 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2BJAEAi045325
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 11 Mar 2012 19:10:14 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2BJAEMO045324;
	Sun, 11 Mar 2012 19:10:14 GMT (envelope-from gnats)
Resent-Date: Sun, 11 Mar 2012 19:10:14 GMT
Resent-Message-Id: <201203111910.q2BJAEMO045324@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Radim Kolar <hsn@sendmail.cz>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5066F10656D1
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sun, 11 Mar 2012 19:09:25 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 022FE8FC0C
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sun, 11 Mar 2012 19:09:25 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q2BJ9OGm094134
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 11 Mar 2012 19:09:24 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q2BJ9OJh094133;
	Sun, 11 Mar 2012 19:09:24 GMT (envelope-from nobody)
Message-Id: <201203111909.q2BJ9OJh094133@red.freebsd.org>
Date: Sun, 11 Mar 2012 19:09:24 GMT
From: Radim Kolar <hsn@sendmail.cz>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: misc/165939: [security bug] incomplete firewall rules loaded if
	tables are used in ipfw.conf
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Mar 2012 19:10:14 -0000


>Number:         165939
>Category:       misc
>Synopsis:       [security bug] incomplete firewall rules loaded if tables are used in ipfw.conf
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 11 19:10:14 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Radim Kolar
>Release:        8.2 amd64
>Organization:
FILEZ.com
>Environment:
>Description:
If user has tables used in /etc/ipfw.conf for example:

table 1 add 64.6.108.239

then firewall restart:

/etc/rc.d/ipfw start

fails with:
Line 8: setsockopt(IP_FW_TABLE_ADD): File exists
Firewall rules loaded.

and incomplete ruleset is loaded. This is serious security problem.

>How-To-Repeat:

>Fix:
in /etc/rc.firewall

after ${fwcmd} -f flush
you need to flush tables too with command

ipfw table all flush

>Release-Note:
>Audit-Trail:
>Unformatted: