From owner-cvs-all@FreeBSD.ORG Mon Aug 21 11:13:44 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1034616A4E0; Mon, 21 Aug 2006 11:13:44 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id A62F343D4C; Mon, 21 Aug 2006 11:13:43 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 747C61A4E0D; Mon, 21 Aug 2006 04:13:43 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id C1AFA51619; Mon, 21 Aug 2006 07:13:42 -0400 (EDT) Date: Mon, 21 Aug 2006 07:13:42 -0400 From: Kris Kennaway To: Kris Kennaway Message-ID: <20060821111342.GB99959@xor.obsecurity.org> References: <200601161951.k0GJpfNx017833@repoman.freebsd.org> <20060821080945.A48690@p-i-n.com> <20060821110753.GA99959@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/NkBOFFp2J2Af1nK" Content-Disposition: inline In-Reply-To: <20060821110753.GA99959@xor.obsecurity.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, "Raphael H. Becker" , cvs-all@freebsd.org, Florent Thoumie Subject: Re: PKGDIR ambiguous (was: cvs commit: src/usr.sbin/pkg_install/info info.h main.c perform.c pkg_info.1 src/usr.sbin/pkg_install/add add.h main.c perform.c pkg_add.1 src/usr.sbin/pkg_install/lib lib.h url.c) X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2006 11:13:44 -0000 --/NkBOFFp2J2Af1nK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 21, 2006 at 07:07:53AM -0400, Kris Kennaway wrote: > On Mon, Aug 21, 2006 at 08:09:45AM +0200, Raphael H. Becker wrote: > >=20 > > Hi Florent, > >=20 > > PKGDIR is ambiguous in the context of ports and packages. > >=20 > > I set PKGDIR=3D/some/where/my/pkg in my /etc/profile which causes the > > ports to fail badly creating any packages: > >=20 > > It is used in ports/Mk/bsd.port.mk: > > # PKGDIR - A directory containing any package creation > > # files. > > # Default: ${MASTERDIR} > > [...] > > PKGDIR?=3D ${MASTERDIR} > >=20 > > Havin set PKGDIR statically is a very bad idea here. >=20 > Yes, PKGDIR is incorrect in this usage. The documented place where > packages are stored is: >=20 > # PACKAGES - A top level directory where all packages go (ra= ther than > # going locally to each port). > # Default: ${PORTSDIR}/packages > # Note that packages are created by 'make package' in *subdirectories* within this directory, as in the FTP site, i.e. All/, with Latest/, ${CATEGORY}/ links. It would be best to be consistent with that approach. Kris --/NkBOFFp2J2Af1nK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFE6ZVmWry0BWjoQKURAkf2AKCGkHYTFMC+1NMvwzRRs1RMaCd3HQCgthry iLAxuZMUCvLha1+5Zi0oLKY= =zqGh -----END PGP SIGNATURE----- --/NkBOFFp2J2Af1nK--