From owner-freebsd-current@FreeBSD.ORG Mon Mar 15 10:50:11 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13FA116A4D0 for ; Mon, 15 Mar 2004 10:50:11 -0800 (PST) Received: from transport.cksoft.de (transport.cksoft.de [62.111.66.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4B4F743D46 for ; Mon, 15 Mar 2004 10:50:10 -0800 (PST) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from transport.cksoft.de (localhost [127.0.0.1]) by transport.cksoft.de (Postfix) with ESMTP id 47EB81FFDC1; Mon, 15 Mar 2004 19:50:08 +0100 (CET) Received: by transport.cksoft.de (Postfix, from userid 66) id 68F771FFDBC; Mon, 15 Mar 2004 19:50:06 +0100 (CET) Received: by mail.int.zabbadoz.net (Postfix, from userid 1060) id 622451538C; Mon, 15 Mar 2004 18:47:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.int.zabbadoz.net (Postfix) with ESMTP id 579F315380; Mon, 15 Mar 2004 18:47:38 +0000 (UTC) Date: Mon, 15 Mar 2004 18:47:38 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@e0-0.zab2.int.zabbadoz.net To: Colin Percival In-Reply-To: <6.0.1.1.1.20040315164047.03bd0ea8@imap.sfu.ca> Message-ID: References: <6.0.1.1.1.20040314234126.03adbc50@imap.sfu.ca> <6.0.1.1.1.20040315164047.03bd0ea8@imap.sfu.ca> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS cksoft-s20020300-20031204bz on transport.cksoft.de cc: FreeBSD current mailing list Subject: Re: spaces before tabs X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2004 18:50:11 -0000 On Mon, 15 Mar 2004, Colin Percival wrote: > At 16:28 15/03/2004, David O'Brien wrote: > >Please no! > > > >Not another round of: > > > > ---------------------------- > > date: 1995/05/30 06:29:28; author: rgrimes; state: Exp; lines: +3 -3 > > Remove trailing whitespace. > > ---------------------------- > > > >which touches thousands of files. > > Well, I was looking at *leading* whitespace, not *trailing* whitespace... > > Ok, I'll find something else to play with. :-) perhaps put the patch on the web along with a list of files affected so that people who work on that file can also incorporate the changes. Only by looking at /usr/src/sys/ I can find ~3500 "ignorant" files with some quick-and-dirty-sh-inline-perl-hack (including some false positives from txt files and quoted strings). The follwing numbers are number of "ignorant" lines (one line may "violate" multiple policies): # Do not add whitespace at the end of a line (/\s\n$/) bz@noc:/usr/src/HEAD> grep ^1: style-9-check.out | wc -l 48370 # do not use more spaces than a tab will produce (/\ {8,}/) # assuming ts=8 bz@noc:/usr/src/HEAD> grep ^2: style-9-check.out | wc -l 69900 (33444 with sys/contrib/dev/acpica excluded) # do not use spaces in front of tabs (/\ \t/) bz@noc:/usr/src/HEAD> grep ^3: style-9-check.out | wc -l 14107 # check for non-\n line breaks (/(\r|\r\n)$/) bz@noc:/usr/src/HEAD> grep ^r: style-9-check.out | wc -l 903 If you have a well written script to find them please make it available and let people check sources before committing like portlint is used for ports. -- Greetings Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT 56 69 73 69 74 http://www.zabbadoz.net/