From owner-svn-src-head@FreeBSD.ORG Mon Apr 20 15:19:55 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1EB3D106564A; Mon, 20 Apr 2009 15:19:55 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 0E3B08FC14; Mon, 20 Apr 2009 15:19:55 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n3KFJs8l049993; Mon, 20 Apr 2009 15:19:54 GMT (envelope-from imp@svn.freebsd.org) Received: (from imp@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n3KFJsk5049992; Mon, 20 Apr 2009 15:19:54 GMT (envelope-from imp@svn.freebsd.org) Message-Id: <200904201519.n3KFJsk5049992@svn.freebsd.org> From: Warner Losh Date: Mon, 20 Apr 2009 15:19:54 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r191321 - head/sys/dev/ed X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2009 15:19:55 -0000 Author: imp Date: Mon Apr 20 15:19:54 2009 New Revision: 191321 URL: http://svn.freebsd.org/changeset/base/191321 Log: Sometimes we can call ed_detach() before the mtx has been initialized. Avoid it if it hasn't been initialized. Modified: head/sys/dev/ed/if_ed.c Modified: head/sys/dev/ed/if_ed.c ============================================================================== --- head/sys/dev/ed/if_ed.c Mon Apr 20 15:15:24 2009 (r191320) +++ head/sys/dev/ed/if_ed.c Mon Apr 20 15:19:54 2009 (r191321) @@ -373,7 +373,8 @@ ed_detach(device_t dev) struct ed_softc *sc = device_get_softc(dev); struct ifnet *ifp = sc->ifp; - ED_ASSERT_UNLOCKED(sc); + if (mtx_initialized(ED_MUTEX(sc))) + ED_ASSERT_UNLOCKED(sc); if (ifp) { ED_LOCK(sc); if (bus_child_present(dev)) @@ -388,7 +389,8 @@ ed_detach(device_t dev) ed_release_resources(dev); if (sc->miibus) device_delete_child(dev, sc->miibus); - ED_LOCK_DESTROY(sc); + if (mtx_initialized(ED_MUTEX(sc))) + ED_LOCK_DESTROY(sc); bus_generic_detach(dev); return (0); }