Date: Mon, 06 Feb 2017 09:32:25 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 216823] graphics/mupdf: Build shared libraries Message-ID: <bug-216823-13-ZloCYpQC1R@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-216823-13@https.bugs.freebsd.org/bugzilla/> References: <bug-216823-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216823 Tobias Kortkamp <t@tobik.me> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179642|0 |1 is obsolete| | Attachment #179642|maintainer-approval?(udvzso | Flags|lt@gmail.com) | Attachment #179671| |maintainer-approval?(udvzso Flags| |lt@gmail.com) --- Comment #3 from Tobias Kortkamp <t@tobik.me> --- Created attachment 179671 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D179671&action= =3Dedit libmupdf.diff (In reply to Zsolt Udvari from comment #2) Thanks for testing! (In reply to Zsolt Udvari from comment #1) > I think the mupdf's PORTEPOCH increase a small typo - you want increase P= ORTREVISION (I think) :) I changed PORTVERSION -> DISTVERSION and 1.10a > 1.10.a according to `pkg version -t 1.10a 1.10.a`, so I think a PORTEPOCH bump is needed. But maybe the DISTVERSION change isn't even needed in this case. I'm mostly going by https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.ht= ml and what I had to do with games/iortcw (bug #214959). Anyway I reverted the change and am bumping PORTREVISION instead :) > I'm not expert in .so-files but why do you need SO_MAJOR? I'm not either. AFAIUI, you need to have some kind of indicator for the ABI version of the library. In theory you could have two incompatible libmupdf's on the system e.g. libmupdf.so.1.0 and libmupdf.so.2.0 (e.g. from Mupdf 1.9a or 1.10a) with different binaries linking to either one of them and the dynamic linker needs to be able to distinguish the two. Since Mupdf doesn't include a way to build a shared library in its build system we have to invent your own versioning scheme and set the libs soname appropriately. Take a look at https://www.freebsd.org/doc/en/books/developers-handbook/policies-shlib.htm= l. According to the article I probably should've started SO_MAJOR at 1, so I changed that too. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-216823-13-ZloCYpQC1R>