Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 Oct 2023 15:54:32 -0700
From:      John Baldwin <jhb@FreeBSD.org>
To:        Mitchell Horne <mhorne@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 74e4a8d208f0 - main - pmap: add pmap_kextract(9) man page
Message-ID:  <527ab884-ce06-4325-52a6-7c6dec1af563@FreeBSD.org>
In-Reply-To: <068574a3-f63a-4830-be1d-2a8cd67c1819@freebsd.org>
References:  <202310131827.39DIRXsu082741@gitrepo.freebsd.org> <ZSqXbrd9dn9h5-We@kib.kiev.ua> <068574a3-f63a-4830-be1d-2a8cd67c1819@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 10/14/23 10:34 AM, Mitchell Horne wrote:
> On 10/14/23 10:28, Konstantin Belousov wrote:
>> On Fri, Oct 13, 2023 at 06:27:33PM +0000, Mitchell Horne wrote:
>>> +.Pp
>>> +.Fn vtophys
>>> +is an alias for
>>> +.Fn pmap_kextract
>>> +and behaves identically.
>>> +.Sh RETURN VALUES
>>> +The
>>> +.Fn pmap_kextract
>>> +function will return the physical address
>>> +.Pq Vt vm_paddr_t
>>> +associated with the kernel virtual address
>> and 'associated'?
>>
>> The function returns address of physical memory mapped at the supplied
>> kernel virtual address.
>>
> 
> Sure, this is more accurate.

I suggest tweaking this further just to be very explicit about the type
of address being returned:

The
.Fn pmap_kextract
function returns the physical address of memory mapped at the
kernel virtual address
.Va va .

or some such.

-- 
John Baldwin




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?527ab884-ce06-4325-52a6-7c6dec1af563>