index | | raw e-mail
But maybe just :caution: Cryptographic software requires special care that the project cannot give to pull requests. Warner --0000000000008c8294064846c42d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g= mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Jan 13,= 2026 at 7:56=E2=80=AFAM John Baldwin <<a href=3D"mailto:jhb@freebsd.org= ">jhb@freebsd.org</a>> wrote:<br></div><blockquote class=3D"gmail_quote"= style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p= adding-left:1ex">On 1/12/26 02:37, Warner Losh wrote:<br> > The branch main has been updated by imp:<br> > <br> > URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D7f8b4db9e001= d94974a081e5fd58c4f3994429cb" rel=3D"noreferrer" target=3D"_blank">https://= cgit.FreeBSD.org/src/commit/?id=3D7f8b4db9e001d94974a081e5fd58c4f3994429cb<= /a><br> > <br> > commit 7f8b4db9e001d94974a081e5fd58c4f3994429cb<br> > Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org><br> > AuthorDate: 2026-01-10 16:20:20 +0000<br> > Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2026-01-12 07:18:11 +0000<br> > <br> >=C2=A0 =C2=A0 =C2=A0 github: Add more context to pull requests<br> >=C2=A0 =C2=A0 =C2=A0 <br> >=C2=A0 =C2=A0 =C2=A0 Add code to fetch and decode CODEOWNERS and automa= tically @ people in<br> >=C2=A0 =C2=A0 =C2=A0 the review.<br> >=C2=A0 =C2=A0 =C2=A0 <br> >=C2=A0 =C2=A0 =C2=A0 Create a new file, .github/path-rules.txt that has= a set of paths to<br> >=C2=A0 =C2=A0 =C2=A0 match and specific warnings about that part of the= tree. We'll use this<br> >=C2=A0 =C2=A0 =C2=A0 to try to wave off pull requests in certain areas = of the tree, as well<br> >=C2=A0 =C2=A0 =C2=A0 as remind people when contrib is involved, etc.<br= > >=C2=A0 =C2=A0 =C2=A0 <br> >=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0Netflix<br> > ---<br> >=C2=A0 =C2=A0.github/path-rules.txt=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |= =C2=A0 10 ++++<br> >=C2=A0 =C2=A0.github/workflows/checklist.yml | 106 ++++++++++++++++++++= ++++++++++++++++----<br> >=C2=A0 =C2=A02 files changed, 106 insertions(+), 10 deletions(-)<br> > <br> > diff --git a/.github/path-rules.txt b/.github/path-rules.txt<br> > new file mode 100644<br> > index 000000000000..297cfe8def35<br> > --- /dev/null<br> > +++ b/.github/path-rules.txt<br> > @@ -0,0 +1,10 @@<br> > +#<br> > +# Format the similar to CODEOWNERS: Each line has a path, whitespace = and a<br> > +# message for contributors.<br> > +#<br> > +sys/contrib/device-tree=C2=A0 =C2=A0 =C2=A0 :caution: No changes shou= ld be made here by pull request<br> > +# Catch all<br> > +contrib=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :warning: Con= tributed software usually managed by vendor branch<br> > +crypto=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0:warning= : Contributed crypto software usually managed by vendor branch<br> > +sys/contrib=C2=A0 :warning: Contributed software usually managed by v= endor branch<br> > +sys/crypto=C2=A0 =C2=A0:warning: Contributed crypto software usually = managed by vendor branch<br> <br> sys/crypto isn't really the same.=C2=A0 We store the generated OpenSSL = assembly files there<br> for use by ossl(4), but most of sys/crypto is not vendored (e.g. ccp, the n= on-assembly ossl<br> bits, aesni are all just bespoke).<br></blockquote><div><br></div><div>That= 's the beauty of this: We can have whatever we want here...=C2=A0 These= were placeholders until</div><div>we had more nuanced things. I see things= like openssh in crypto too, so many things are</div><div>vendored there, i= n addition to the mire of inconsistency... First one wins (or did I take th= at out,</div><div>if I did, I should put it back)....=C2=A0 I'd also th= ought this might couple well with the 3rd party audit</div><div>and we coul= d generate some json from that to give upstream pointers, project contacts,= etc</div><div>around all that.</div><div><br></div><div>But maybe just</di= v><div><br></div><div>:caution: Cryptographic software requires special car= e that the project cannot give to pull requests.</div><div><br></div><div>W= arner</div></div></div> --0000000000008c8294064846c42d--home | help