From owner-freebsd-arch@FreeBSD.ORG Wed Jan 8 01:26:16 2014 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E348C171; Wed, 8 Jan 2014 01:26:16 +0000 (UTC) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C1AB6149C; Wed, 8 Jan 2014 01:26:16 +0000 (UTC) Received: from zeta.ixsystems.com (unknown [69.198.165.132]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id 5CF8229B9B; Tue, 7 Jan 2014 17:26:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1389144376; bh=GVtc33UmgKnESskjie0ZDY5GxWFkRrvckzMQqWx6MHI=; h=Date:From:Reply-To:To:Subject:References:In-Reply-To; b=tCEZhX+qvDcfmejo2ZnsTqWBdihcEoqWfl6MRniHKUUN9OPb++1KqCk7Y+gNitCJ3 f/Y8zJavgbLN/9t67extnlRyQOXrnpkxI4uVk3ilXF1ChtIT5LvXBBspZQhRf9OHu7 GMR7S2kVjsHpcjS10cL++UkXc09mJK7iRXygaNgk= Message-ID: <52CCA937.7080301@delphij.net> Date: Tue, 07 Jan 2014 17:26:15 -0800 From: Xin Li Organization: The FreeBSD Project MIME-Version: 1.0 To: Adrian Chadd , "freebsd-arch@freebsd.org" Subject: Re: [rfc] sendfile: refactor out common sendfile code into _do_sendfile() References: In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: d@delphij.net List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jan 2014 01:26:17 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 01/07/14 16:56, Adrian Chadd wrote: > Hi, > > http://people.freebsd.org/~adrian/netflix/20140107-freebsd-sendfile-refactor-1.diff > > This refactors out the common code from both the sendfile and > compat32 sendfile calls into a shared function. That way I can > extend the sendfile behaviour and only have to update one > location. > > What do people think? I think this would be a good idea, but can we call _do_sendfile something different? (Maybe call the current do_sendfile "sendfile_common", and _do_sendfile "do_sendfile"?) ('compat' seems to be a bad name, by the way. Maybe we can just get rid of the inner test and just pass SFK_COMPAT as 'flag'?) Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJSzKk3AAoJEJW2GBstM+nskVsP/jMTYp8yHH650N2o0CJ5Goly SWZSPSGdgsOtL1XifX5pkO77KuR6/3IP5dr3ilUlaYHT0HK1Y5+gKPOW+cgcaPAQ +RjVMCxtfnugo3VE5zI6H4cvxgPxXISynSr7zaQ5WUlC3moTLxrpZ8wOwvkDEwIC V/Rlb4y0ohHXezH3aBgdCP41jkOxYjCgQjHxviexDcv8zMlgi9CCOxoihFaPczwW 8I0E8RPzyIHZVIZtFnHYpomaFsHAJxR7KJjc9YUGnyTdSnwKwEYv5PON0BYM7NVX erG9vK9ro7hRV5ZELlxc1GsdgKQZ2JUkJr0vT1VKP55LHgsxwPIzfySHiqHV3RTc s2el2ps0kP9rU9E5M5KIsV59RAo4Wzu53bIohg1hf02VBAPbSUe0ATqM+wxgb5MB oiA2zyw3bmRdSmAIttda2F+bAQkZpPaur3PnJuxicktvEeX+CuqeXHZfebFSKVvi B2QR6KCSsMRJhYJn7FVnL2pbTAOur/EmLudYHngnQc8UK3YBBIt+7KOirOEIwyd0 WPU9Rp21UGXTTm3uy0WyQs3yrDeFaHE2ebhczV2PLdFSSqqif53pw3xGTwRQBHW0 BP9QcNEribvsHdMqdr9Fv6/vBXosVzleUmG2raM+vvIHrOGVP8diVGOOAqGXdBtW Q5nZoSc9nBEteTuGZs2N =OBCI -----END PGP SIGNATURE-----