Date: Sat, 17 Dec 2005 13:09:21 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Scot Hetzel <swhetzel@gmail.com> Cc: Brooks Davis <brooks@one-eyed-alien.net>, Pav Lucistnik <pav@freebsd.org>, "Simon L. Nielsen" <simon@freebsd.org>, freebsd-ports@freebsd.org Subject: Re: Conflicting rc.d script and port dist directory Message-ID: <20051217210921.GF29053@odin.ac.hmc.edu> In-Reply-To: <790a9fff0512171305j45b46593j683be6227366d71c@mail.gmail.com> References: <20051217201004.GA845@zaphod.nitro.dk> <1134850440.64549.0.camel@localhost> <20051217203912.GD29053@odin.ac.hmc.edu> <790a9fff0512171305j45b46593j683be6227366d71c@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Wb5NtZlyOqqy58h0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Dec 17, 2005 at 03:05:48PM -0600, Scot Hetzel wrote:
> On 12/17/05, Brooks Davis <brooks@one-eyed-alien.net> wrote:
> > On Sat, Dec 17, 2005 at 09:13:59PM +0100, Pav Lucistnik wrote:
> > > Simon L. Nielsen p=ED?e v so 17. 12. 2005 v 21:10 +0100:
> > > > Hey,
> > > >
> > > > I'm in the process of adding an rc.d script to the security/isakmpd
> > > > port, but I have run into a problem.
> > > >
> > > > I have added "USE_RC_SUBR=3D isakmpd" to the port Makefile and crea=
ted
> > > > the rc.d script as files/isakmpd.in.
> > > >
> > > > The isakmpd distfile extracts the source to isakmpd/ in the the work
> > > > directory, which the conflicts with the rc.d script generation
> > > > (SUB_FILES), since it tries to create ${WRKDIR}/${file} as a file.
> > > > This shows up during make install:
> > > >
> > > > [simon@zaphod:isakmpd] sudo make install
> > > > =3D=3D=3D> Installing for isakmpd-20041207_1
> > > > cannot create /data/tmp/porttmp/home/simon/FreeBSD/ports/isakmpd/wo=
rk/isakmpd: Is a directory
> > > > *** Error code 2
> > > >
> > > > So, does anybody have good (and hopefully not to hackish) ideas of
> > > > what to do?
> > >
> > > Yes. Name the script isakmpd.sh.in ...
> > >
> > > The framework will add the .sh suffix anyway.
> >
> > That would be a hack since we don't want to continue adding .sh...
> >
> I don't see this as a hack. Any rc.d script placed in ${WORK}
> directory should have the .sh extention to avoid conflicts with
> similar named directories. When the port installs the rc.d script, it
> should check OSVERSION to determine if the script should be
> installed/not-installed with the .sh suffix.
I guess that makes sense. It would be nice if we made up our minds what
the source extension and variable values should be.
-- Brooks
--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4
--Wb5NtZlyOqqy58h0
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQFDpH6AXY6L6fI4GtQRApcjAKCTxqkmBDiC+9DwQQ3ywJMkuSuUJACfQs4K
Dow4jSSgEMKtEQIDF8XNHwI=
=u6ms
-----END PGP SIGNATURE-----
--Wb5NtZlyOqqy58h0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051217210921.GF29053>