From owner-svn-ports-all@FreeBSD.ORG Wed Apr 3 19:27:40 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 78C8BC17 for ; Wed, 3 Apr 2013 19:27:40 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-ve0-f173.google.com (mail-ve0-f173.google.com [209.85.128.173]) by mx1.freebsd.org (Postfix) with ESMTP id 33AB19CE for ; Wed, 3 Apr 2013 19:27:39 +0000 (UTC) Received: by mail-ve0-f173.google.com with SMTP id cy12so1993598veb.4 for ; Wed, 03 Apr 2013 12:27:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=zxuxN0UGq73SAWaCNa4J1kQBfEwordotaWIrasYe8h8=; b=k/FUfw1/yxxGJ8sl9ZM6HdV29fIpT0oohfxxqhSEzEp6pD+K8caqaRs74Lj4yY0NmH oZuco/Z9WS2V4Joru6c3GvFBqigDhulv+hvKlRnBTWwvKdYnwTKgoDSnWF06DbbvMnnm KCaJj7gfX8AVPVO0XkoxSX2m/jeRbHSFaPADVXGzJlz27ocw2PQYh6p7PqB+iC39W7+h RJB8lIR3enWRYEPeKBvfnbO8sghxBHyEnvC6FaNXCfYvJXeVin4AdL9LN7ctH/ituz0N xaUaZH76DW8xeFOtNS2YcVjeqx83ziEMNoOX91920fjwLuMVNmyDMIy+mzsd3KyIwb3m /pAA== MIME-Version: 1.0 X-Received: by 10.52.29.18 with SMTP id f18mr2011880vdh.57.1365017259148; Wed, 03 Apr 2013 12:27:39 -0700 (PDT) Sender: bsd-src@helfman.org Received: by 10.59.13.67 with HTTP; Wed, 3 Apr 2013 12:27:39 -0700 (PDT) In-Reply-To: <2621916.z1b9zmMaju@mercury.ph.man.ac.uk> References: <201303251359.r2PDxIXf035701@svn.freebsd.org> <20130328030757.GB83712@FreeBSD.org> <2621916.z1b9zmMaju@mercury.ph.man.ac.uk> Date: Wed, 3 Apr 2013 12:27:39 -0700 X-Google-Sender-Auth: DpIHCqYfA7DDpF8CvMpeiMLAuOA Message-ID: Subject: Re: svn commit: r315222 - in head: devel/qdevelop games/warmux graphics/xaos math/qtiplot multimedia/minitube print/hplip textproc/qstardict From: Jason Helfman To: Max Brazhnikov X-Gm-Message-State: ALoCoQmi6QqaADuMvmBq8/0Ow8pVvOj+bqxC+cFqcCicvkmg1aeTK+jmtVVMPd8VoDExqjH07KrI Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "svn-ports-head@freebsd.org" , Baptiste Daroussin , "svn-ports-all@freebsd.org" , Alexey Dokuchaev , "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2013 19:27:40 -0000 On Wed, Apr 3, 2013 at 10:36 AM, Max Brazhnikov wrote: > On Thu, 28 Mar 2013 03:07:57 +0000 Alexey Dokuchaev wrote: > > On Wed, Mar 27, 2013 at 10:57:34PM -0400, Eitan Adler wrote: > > > On 27 March 2013 22:53, Alexey Dokuchaev wrote: > > > > On Mon, Mar 25, 2013 at 01:59:18PM +0000, Max Brazhnikov wrote: > > > >> New Revision: 315222 > > > >> URL: http://svnweb.freebsd.org/changeset/ports/315222 > > > >> > > > >> - Remove OPTIONS_DEFINE, if it contains only global options > > > > > > > > Can you elaborate on this one? Given that there is no clear policy, > > > > personally I've been always including OPTIONS_DEFINE, even if just > for, > > > > say, DOCS. > > > > > > Options such as IPV6, DOCS, EXAMPLES, and NLS are generally set > > > globally (e.g., OPTIONS_UNSET= NLS) and not per port. As such, it can > > > reduce user annoyance if the dialog box is not shown for such options. > > and it keeps status quo with old options framework, when DOCS/EXAMPLES > were not > usually added to the options list, apparently because bsd.port.mk checked > only > for NOPORT* variables. > > > Yes, I've heard that reasoning. I'm not particularly against it, but I > > am also worried about certain inconsistency: it means, that for a port > > with at least one "local" option, users can toggle all of them, while for > > others they had to rely on their /etc/make.conf settings (or defaults). > > I agree with you about inconsistency. I'm fine with any policy once it's > settled. > > Max > > I'm fine with any policy, however it seems that there is inconsistency in what I've heard for defining, as well. Why not have a policy first, then implement/document? -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve