From nobody Sat Dec 3 15:38:49 2022 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NPYrB0L2sz4jgLR for ; Sat, 3 Dec 2022 15:38:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NPYr95mQdz3phH for ; Sat, 3 Dec 2022 15:38:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670081929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SicNmQeauy65O4pKC8m3xVEaghgpGES4lC0x67pnL+o=; b=OROoxlbBB/nb92cFUFHfRdeYXZYxYD2qCQTP1Vys4s2VXZEf1yegI6Dlx4EM0pquBTWhd7 4R/QT5d/EZcMFJ6asf0H2qGM9oI4iLOdOpZ463y1y8Y8gKuPZfSyd8bHXQ+OTxwfHIUX+/ c/JiO/F9b1JoK0yvDBJqIe7Gb89sUr3vJw9yNOde86+mDEQGOiPG9nbMbTScMlwalswtU/ xTEEIYwlZf0yYIPiDZJC5VLKuu06iLuQU5dsoreLx15ttpryMkTq7QaEORu06ZHIsnOz8T dVnTEAnxDxRmQm1sLInD9TKzpDJBP7hMIbcaAaaBB5+6f812a9GtD/0gCbCfaw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670081929; a=rsa-sha256; cv=none; b=ip/oUJv9fiqlYNy5+eZ86aPXIvO5Wkzx4RujODdmVMl3gfpBHfAhV1wJReCmvTGDKhdXK5 LrKLmRR8krlLT7f0MDZiN50ZohJCjPhGiWDIRPjD8E1Fhn0taR9g4aeiTJTbXGLg12ucqF ty34cmjj0GQlDKsNQPYs1oyRes1KQP2D82VDBOgNHJj8E+nDrb+pM12GSW5yG9kchBDZRm L5YqPneBcjxUvtG5WdZUWTq8bc4U4DO5FjqeLqqwjHxul5PwBLkdMdgtXnpVA/Z2OiRv/j O7pMo+1bxA5Et3OzFFp+UKglyNcTdmt+ivcB5eTLJ9FvdMqCHxVdfbA62XFknw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NPYr94k8Yz10Nw for ; Sat, 3 Dec 2022 15:38:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2B3Fcnq2003587 for ; Sat, 3 Dec 2022 15:38:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2B3FcnwD003585 for virtualization@FreeBSD.org; Sat, 3 Dec 2022 15:38:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 267539] Bhyve virtio-scsi warnings about illegal SCSI tag reuse Date: Sat, 03 Dec 2022 15:38:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267539 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D0acc026dda9e7405f7a88993d1b51e5fc= 846cbc5 commit 0acc026dda9e7405f7a88993d1b51e5fc846cbc5 Author: Alexander Motin AuthorDate: 2022-12-03 15:23:29 +0000 Commit: Alexander Motin CommitDate: 2022-12-03 15:23:29 +0000 CTL: Increase maximum SCSI tag size from 32 to 64 bits. SAM-5 specification states maximum size of command identifier (tag), defined by specific transports, should not be larger than 64 bits. While most of supported transports use 32 bits or less, it was reported that virtio-scsi uses 64 bits. Truncation to 32 bits in bhyve code caused false tag conflict errors reported and possibly other issues. This changes CTL ABI and HA protocol, so CTL_HA_VERSION is bumped. While we make HA protocol incompatible, increase default maximum number of ports in CTL from 256 to 1024, matching number of LUNs. There are many reports from people who need many iSCSI targets with only one LUN each. Increased memory consumption should be less of a problem these days. PR: 267539 share/man/man4/ctl.4 | 2 +- sys/cam/ctl/ctl.c | 13 +++++++------ sys/cam/ctl/ctl_frontend_ioctl.c | 4 ++-- sys/cam/ctl/ctl_io.h | 11 +++++------ sys/cam/ctl/ctl_ioctl.h | 3 ++- sys/cam/ctl/ctl_tpc_local.c | 2 +- sys/cam/ctl/ctl_util.c | 6 +++--- sys/cam/ctl/scsi_ctl.c | 2 +- usr.sbin/bhyve/pci_virtio_scsi.c | 4 ++-- 9 files changed, 24 insertions(+), 23 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=