From owner-freebsd-current@FreeBSD.ORG Tue Aug 17 16:04:53 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B480106567A for ; Tue, 17 Aug 2010 16:04:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id A9F3C8FC14 for ; Tue, 17 Aug 2010 16:04:52 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o7HG4kh5035598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 17 Aug 2010 19:04:46 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o7HG4kl1006329; Tue, 17 Aug 2010 19:04:46 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o7HG4jxA006328; Tue, 17 Aug 2010 19:04:45 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 17 Aug 2010 19:04:45 +0300 From: Kostik Belousov To: pluknet Message-ID: <20100817160445.GO2396@deviant.kiev.zoral.com.ua> References: <20100816185456.GU2396@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+aJhGqIeocQJJWbN" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.2 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_50, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: FreeBSD Current Subject: Re: LOR on nfs: vfs_vnops.c:301 kern_descrip.c:1580 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Aug 2010 16:04:53 -0000 --+aJhGqIeocQJJWbN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 17, 2010 at 07:42:41PM +0400, pluknet wrote: > 2010/8/16 Kostik Belousov : > > On Mon, Aug 16, 2010 at 09:07:24PM +0400, pluknet wrote: > >> On 16 August 2010 21:05, pluknet wrote: > >> > Hi. > >> > > >> > Seeing on mostly idle, recently updated current, while closing a fil= e. > >> > Presumably never reported on ML. > [...] > >> > > Both LORs are valid. The fork performed deep inside the VFS call stack > > is obviously problematic. As a workaround, you may fix the number of > > nfsiods. > > > > Proper fix might consist of creating a shepherd thread which only task > > is to act on the requests on creating new nfsiods. > > > > Would you try to implement this ? I will provide the assistance, if nee= ded. >=20 > Hmm.. I tried to move kproc_create() under shepherd thread and now stuck > with cp process lockup in [bo_wwait] when cp'ing something on nfs: cp a b. > Did I screw up something? > See weird draft patch attached (weird, as I have no idea how to nicely > exchange data between nfs_nfsiodnew() and shep_thread() thread). Most likely, you loose the requests to create nfsiods since the existing request in the global variable shep_chan can be overwritten by new request. You should either sleep till existing request is serviced, or form a queue. Also please take a note of the John' suggestion to use the taskqueue. --+aJhGqIeocQJJWbN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkxqsx0ACgkQC3+MBN1Mb4jIygCeJaFieJ7FfnurFjWPQZnUs7rQ rXsAoIv8Wn5f4F0MSC7sd085LRZzIhwD =JJsd -----END PGP SIGNATURE----- --+aJhGqIeocQJJWbN--