From owner-freebsd-ports  Wed Feb  5  8: 9:14 2003
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D657D37B401; Wed,  5 Feb 2003 08:09:12 -0800 (PST)
Received: from baraca.united.net.ua (ns.united.net.ua [193.111.8.193])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8470443F75; Wed,  5 Feb 2003 08:09:10 -0800 (PST)
	(envelope-from sobomax@portaone.com)
Received: from vega.vega.com (root@xDSL-2-2.united.net.ua [193.111.9.226])
	by baraca.united.net.ua (8.12.6/8.12.6) with ESMTP id h15G91wb010149;
	Wed, 5 Feb 2003 18:09:03 +0200 (EET)
	(envelope-from sobomax@portaone.com)
Received: from portaone.com (big_brother.vega.com [192.168.1.1])
	by vega.vega.com (8.12.6/8.12.5) with ESMTP id h15G9LUk041325;
	Wed, 5 Feb 2003 18:09:21 +0200 (EET)
	(envelope-from sobomax@portaone.com)
Message-ID: <3E413726.7AF3B256@portaone.com>
Date: Wed, 05 Feb 2003 18:09:10 +0200
From: Maxim Sobolev <sobomax@portaone.com>
Organization: Porta Software Ltd
X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U)
X-Accept-Language: en,uk,ru
MIME-Version: 1.0
To: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
Cc: Maxim Sobolev <sobomax@freebsd.org>, ports@freebsd.org,
	portmgr@freebsd.org
Subject: Re: USE_GETOPT patch available
References: <20030205011921.24c642cb.corecode@corecode.ath.cx>
		<20030205010005.GA35933@vega.vega.com> <20030205024524.2edc919c.corecode@corecode.ath.cx>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org

Simon 'corecode' Schubert wrote:
> 
> Lately Maxim Sobolev told:
> 
> > I think that you had overcomplicated things a bit, with all those
> > automagick. Something like the following would be more than enough:
> 
> [code sets GNUGETOPT_{CFLAGS,LIBS}]
> 
> but how does configure/make get these?
> 
> ${SETENV} can't accumulate variables (like env CFLAGS=foo CFLAGS=bar)
> 
> okay, one simple fix could be just adding LDFLAGS to the environment of
> configure (not CONFIGURE_ENV) and then preventing ports to set
> CFLAGS/LDFLAGS. does that seem reasonable?

foo/Makefile:

USE_GNUGETOPT=yes
CONFIGURE_ENV=CPPFLAGS="${GNUGETOPT_CFLAGS} -ISOME -DOTHER -FLAGS"
LIBS="${GNUGETOPT_LIBS}"

The reason why I think that automatic addition into CONFIGURE_ENV is
Bad Thing[tm] is because user might have other options in
CPPFLAGS/LIBS, in that case your patch will wanish them.

-Maxim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message