From owner-freebsd-ports@FreeBSD.ORG  Tue Oct  9 18:38:04 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id B51DA6B5
 for <ports@FreeBSD.org>; Tue,  9 Oct 2012 18:38:04 +0000 (UTC)
 (envelope-from ohauer@gmx.de)
Received: from mailout-de.gmx.net (mailout-de.gmx.net [213.165.64.22])
 by mx1.freebsd.org (Postfix) with SMTP id 08D498FC14
 for <ports@FreeBSD.org>; Tue,  9 Oct 2012 18:38:03 +0000 (UTC)
Received: (qmail invoked by alias); 09 Oct 2012 18:38:02 -0000
Received: from p578be941.dip0.t-ipconnect.de (EHLO [192.168.0.100])
 [87.139.233.65]
 by mail.gmx.net (mp072) with SMTP; 09 Oct 2012 20:38:02 +0200
X-Authenticated: #1956535
X-Provags-ID: V01U2FsdGVkX1/E9kpy8QHEQl7EBmEtgRY1CBFyNfGaPLUSHrsMzd
 Ix00VdeS7JBvoI
Message-ID: <50746F09.1000701@gmx.de>
Date: Tue, 09 Oct 2012 20:38:01 +0200
From: olli hauer <ohauer@gmx.de>
User-Agent: Mozilla/5.0 (Windows NT 5.1;
 rv:15.0) Gecko/20120907 Thunderbird/15.0.1
MIME-Version: 1.0
To: Pierre DAVID <pdagog@gmail.com>
Subject: Re: help wanted: ports for the Netmagis software
References: <20121009122724.GA69926@vagabond.u-strasbg.fr>
In-Reply-To: <20121009122724.GA69926@vagabond.u-strasbg.fr>
X-Enigmail-Version: 1.4.4
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
Cc: FreeBSD Ports <ports@FreeBSD.org>
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Oct 2012 18:38:04 -0000

On 2012-10-09 14:27, Pierre DAVID wrote:
> Hi,
> 
> would anybody help me to bring these ports in final shape such as
> they could be included in the ports tree?
> 
> Thanks in advance,
> 
> Pierre David

Hi David,

I haven't tried a test build and your ports are looking good at the first investigate.

Anyway I have some minor changes.

- adopt new makefile header (all Makefiles)

- netmagis-common
 - no entries after bsd.port.mk (netmagis-common)
 - distinfo is out of date (what was changed ? same version number)
 - use LOGIN instead DEAMON in rc scripts (user->rancid)

- netmagis-database
 - is it possible to change /usr/local/var/netmagis to /var/netmagis?
   or is this directory similar to the rancid repo dirs and adjustable?

- netmagis-www
 - is it possible to use a common WWWDIR together with netmagis-metro?
   if yes, we can set a common WWWDIR in netmagis-common and adjust
   metro.

- a couple of dirrm -> dirrmtry
   where I suspect tmp files or user data which should be
   protected during updates, but you should know the places better then I ;)

Could you take a look into the following diff and maybe test the WWWDIR adjustments.
http://people.freebsd.org/~ohauer/diffs/netmagis.diff

--
Regards,
olli