From owner-cvs-all Mon Feb 11 17: 4:44 2002 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 6C6FA37B419; Mon, 11 Feb 2002 17:04:34 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id g1C14VR93342; Tue, 12 Feb 2002 04:04:32 +0300 (MSK) (envelope-from ache) Date: Tue, 12 Feb 2002 04:04:29 +0300 From: "Andrey A. Chernov" To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/security/drweb-sendmail Makefile ports/security/drweb-sendmail/files Makefile.libmilter patch-ab patch-ad Message-ID: <20020212010427.GA93193@nagual.pp.ru> References: <200202112242.g1BMg2I04645@freefall.freebsd.org> <20020212003407.GG82640@squall.waterspout.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020212003407.GG82640@squall.waterspout.com> User-Agent: Mutt/1.3.27i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Feb 11, 2002 at 19:34:07 -0500, Will Andrews wrote: > On Mon, Feb 11, 2002 at 02:42:02PM -0800, Andrey A. Chernov wrote: > > Log: > > Add -D_THREAD_SAFE, remove libsmutil building > > Use CFLAGS+=${PTHREAD_CFLAGS}, not this. I doubt that PTHREAD_CFLAGS definition for recent -current (as "") is correct, see include/rpc/clnt.h Moreover, -D_THREAD_SAFE still in the lib/libc_r/Makefile. All it looks like it is needed for recent -current too. > Also, you broke > guidelines which say you're supposed to use the same patch file > for the same patched file in the source. In patch-ab's case > you've patched src/Makefile.bsd when it was dw_filter.c. patch-ab was removed long time ago. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message