From owner-freebsd-ports@FreeBSD.ORG Fri Sep 20 05:32:05 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B98D62DE for ; Fri, 20 Sep 2013 05:32:05 +0000 (UTC) (envelope-from FreeBSD@shaneware.biz) Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [IPv6:2001:44b8:8060:ff02:300:1:6:4]) by mx1.freebsd.org (Postfix) with ESMTP id 52EAF2F03 for ; Fri, 20 Sep 2013 05:32:04 +0000 (UTC) Received: from ppp118-210-231-94.lns20.adl6.internode.on.net (HELO leader.local) ([118.210.231.94]) by ipmail04.adl6.internode.on.net with ESMTP; 20 Sep 2013 15:02:01 +0930 Message-ID: <523BDDCE.4060801@ShaneWare.Biz> Date: Fri, 20 Sep 2013 15:01:58 +0930 From: Shane Ambler User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130516 Thunderbird/17.0.6 MIME-Version: 1.0 To: FreeBSD-ports Subject: libc++ differences between 9.2 and 10.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2013 05:32:05 -0000 I'm Starting to look at fixing my ports to build on 10.0 and there appears to be a difference between 9.2 and 10.0 when it comes to using libc++ The first port I am looking at is graphics/opencolorio. a patch was submitted (ports/182220) that works fine on 10.0 but it breaks 9.2 build when using clang with - error: no type named 'shared_ptr' in namespace 'std' The patch is simple, just adding - #elif __cplusplus >= 199711 #include #define OCIO_SHARED_PTR std::shared_ptr #define OCIO_DYNAMIC_POINTER_CAST std::dynamic_pointer_cast As far as I can see both 10.0 and 9.2 use the same contrib/libc++ contents but I don't see why 9.2 isn't finding std::shared_ptr The other thing is I don't think testing __cplusplus is the right way to go but don't see an alternative. __cplusplus is defined in clang irrespective of the library used so isn't really a reliable test. Are there any defines to easily test for std::shared_ptr or is that a test I need to create for configure or cmake - has already been done?