From owner-freebsd-bugs  Wed Aug 15  4:10:19 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 655F437B40C
	for <freebsd-bugs@hub.freebsd.org>; Wed, 15 Aug 2001 04:10:05 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f7FBA5H89733;
	Wed, 15 Aug 2001 04:10:05 -0700 (PDT)
	(envelope-from gnats)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 9840437B40A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 15 Aug 2001 04:03:53 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f7FB3rl86388;
	Wed, 15 Aug 2001 04:03:53 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200108151103.f7FB3rl86388@freefall.freebsd.org>
Date: Wed, 15 Aug 2001 04:03:53 -0700 (PDT)
From: Katsuyuki Yumoto <yumoto@jpn.hp.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: kern/29727: amr_enquiry3 structure in amrreg.h (amr driver) is incorrect.
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         29727
>Category:       kern
>Synopsis:       amr_enquiry3 structure in amrreg.h (amr driver) is incorrect.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 15 04:10:04 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Katsuyuki Yumoto
>Release:        4.3R
>Organization:
HP Japan
>Environment:
>Description:
In the amr_enquiry3 structure described in amrreg.h file, 
Please make sure ae_drivestate is not physical drive state but logical one.
Also ae_phydrivestate has to follow it.

>How-To-Repeat:
getting result of amr_enquiry3 structure by issuing Enq3 command via ioctl().




>Fix:
apply following patch

diff -u -N -r sys.b/dev/amr/amrreg.h sys/dev/amr/amrreg.h
--- sys.b/dev/amr/amrreg.h      Tue Aug 14 18:38:41 2001
+++ sys/dev/amr/amrreg.h        Tue Aug 14 18:37:54 2001
@@ -341,7 +341,8 @@
     u_int16_t  ae_opstatus[AMR_40LD_MAXDRIVES / 8];    /* operation status per
drive */
     u_int32_t  ae_drivesize[AMR_40LD_MAXDRIVES];       /* logical drive size */
     u_int8_t   ae_driveprop[AMR_40LD_MAXDRIVES];       /* logical drive propert
ies */
-    u_int8_t   ae_drivestate[AMR_40LD_MAXDRIVES];      /* physical drive state
*/
+    u_int8_t   ae_drivestate[AMR_40LD_MAXDRIVES];      /* logical drive state *
/
+    u_int8_t   ae_phydrivestate[AMR_40LD_MAXDRIVES];   /* physical drive state
*/
     u_int16_t  ae_driveformat[AMR_40LD_MAXPHYSDRIVES];
     u_int8_t   ae_targxfer[80];                        /* physical drive transf
er rates */

>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message