Date: Sun, 24 Sep 2006 11:29:59 +0400 From: Stanislav Sedov <stas@FreeBSD.org> To: Kris Kennaway <kris@obsecurity.org> Cc: cvs-ports@FreeBSD.org, sem@FreeBSD.org, Rainer Alves <rainer.alves@gmail.com>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/multimedia/avifile Makefile ports/multimedia/avifile/files patch-lib_aviread_ReadFile.cpp Message-ID: <20060924112959.0f77617a@localhost> In-Reply-To: <20060923222717.GA12790@xor.obsecurity.org> References: <200609231621.k8NGLNJF090082@repoman.freebsd.org> <20060923222717.GA12790@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_QoiCdtYHjotweHc5ilkyHg8 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable On Sat, 23 Sep 2006 18:27:17 -0400 Kris Kennaway <kris@obsecurity.org> mentioned: > On Sat, Sep 23, 2006 at 04:21:23PM +0000, Stanislav Sedov wrote: > > stas 2006-09-23 16:21:23 UTC > >=20 > > FreeBSD ports repository > >=20 > > Modified files: > > multimedia/avifile Makefile=20 > > Added files: > > multimedia/avifile/files patch-lib_aviread_ReadFile.cpp=20 > > Log: > > - Fix building with recent version of gcc (3.4.6) [1] > > - Test for pcvt_ioctl.h existence as it was removed recently. > > Include iokb.h instead if its'nt exists. [1] >=20 > .if exists() tests to control build behaviour are usually bogus, use > an OSVERSION test instead. >=20 > Kris I was thinking about it, but unfortunately there was no revision bump after the pcvt(4) removal. Thus I decided to explicitly check for the existence. --=20 Stanislav Sedov <stas@FreeBSD.org> [[=F2=CF=D3=D3=C9= =D1, =ED=CF=D3=CB=D7=C1]] PGP id: 0xEB269581 http://people.freebsd.org/~stas/stas.key.asc --Sig_QoiCdtYHjotweHc5ilkyHg8 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFFjP8K/VZk+smlYERAl4PAJ0dtE/+YoPxpjjkVN+hgiwr9+dUKwCfWDgP h6VgssLf5Mj8EM8oZHNovOE= =7KRt -----END PGP SIGNATURE----- --Sig_QoiCdtYHjotweHc5ilkyHg8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060924112959.0f77617a>