From owner-freebsd-current@freebsd.org Thu May 24 18:50:02 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 62472EFB2FA for ; Thu, 24 May 2018 18:50:02 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 000847D6D2; Thu, 24 May 2018 18:50:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id C3A62F721; Thu, 24 May 2018 18:50:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 81F2DF5A; Thu, 24 May 2018 18:50:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 4jWJmYBEq-C9; Thu, 24 May 2018 18:49:58 +0000 (UTC) Subject: Re: Another recent WITH_META_MODE= gotcha ": handling svn commit: r334008 - head/bin/sh DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com CAE3CF55 To: Mark Millard , FreeBSD Current Cc: Cy.Schubert@cschubert.com, "O. Hartmann" References: <2E8F4907-F2AD-4EAD-A78F-E3236E516C8B@yahoo.com> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Autocrypt: addr=bdrewery@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFJphmsBCADiFgmS4bIzwZijrS31SjEMzg+n5zNellgM+HkShwehpqCiyhXdWrvH6dTZ a6u50pbUIX7doTR7W7PQHCjCTqtpwvcj0eulZva+iHFp+XrbgSFHn+VVXgkYP2MFySyZRFab D2qqzJBEJofhpv4HvY6uQI5K99pMqKr1Z/lHqsijYYu4RH2OfwB5PinId7xeldzWEonVoCr+ rfxzO/UrgA6v/3layGZcKNHFjmc3NqoN1DXtdaEHqtjIozzbndVkH6lkFvIpIrI6i5ox8pwp VxsxLCr/4Musd5CWgHiet5kSw2SzNeA8FbxdLYCpXNVu+uBACEbCUP+CSNy3NVfEUxsBABEB AAHNJEJyeWFuIERyZXdlcnkgPGJkcmV3ZXJ5QEZyZWVCU0Qub3JnPsLAgAQTAQoAKgIbAwUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAIZAQUCWujOIgUJCmB7NwAKCRA113G7bkaXz/xpB/9b /UWIPbieY1IeIuHF2pyYPE7Hytkh3HVsxMA0F5Ma2AYQsXZZeKNKWrF7RPyDyDwUklLHJkhm k3EfClBbHxf08kMIm1vWCJRtgxic9knY/bzYGiWMpHjg3cSd1XfrYH1autYqTZAjDwIkgOjU dR//Tbn4V36sY7y2jz+kdMVWvK53U32aZqiwBbCn4DPe1wSZcUs17mV/0uZdIoGdj74B1orN A/0py5vHYo6HcbBNoaR8pKRLf5VZNRsxqGIMhTucx4SJWcHpuRBWYyvJSFzwvxdK4ZD4Yqoc kFGPVtOXktVMai9exrLvP3G77fKMu8DI6j4QRU4wCesnHuIfRPFuzsBNBFJphmsBCACiVFPf kNfaFtUSuY0395ueo/rMyHPGPQ2iwvERFCpeFGSQSgagpenNHLpFQKTg/dl6FOoST5tqyxMq fyHGHDzzU51bvA/IfaGoNi/BIhTe/toZNMRvpcI3PLjiGcnJnuwCCbAVOAGdb+t5cZtpNdOI cKYmrYG3u9RiBpe6dTF+qLrD/8Bs1wjhduQ8fcNNgnkXu8xDH4ZxY0lIc3QgvYWp9vimlQe6 iKjUd2/DX28ETZcD5h6pYV331KMPTrEI0p0yvFijUZce8c1XHFyL1j9sBAha5qpszJl6Uq5i LolhKRcGfcdmtD72vHQjUYglUyudSJUVyo2gMYjdbiFKzJulABEBAAHCwGUEGAEKAA8CGwwF AlrozigFCQpgez0ACgkQNddxu25Gl8+m5Af/R3VEdxNMAcDIes9ADhQyofj20SPV3eCJ3HYR OebTSuNdOudGt4AAyA8Ks94u9hiIp5IGsc6RDsT9W7O2vgXhd6eV3eiY5Oif5xLIYrIDVu1Y 1GyRxRrPEn/QOqDN6uFZCPwK1aOapGcYCrO9lB0gMuTVfgHanU61rgC9tMX0OoAOyRd+V3/M 8lDNhjJdF/IpO3SdYzKfkwduy4qamw4Gphcx/RfYQvYLq/eDkP8d50PphWdboqWBwNRHayro W/07OGzfxM5fJ5mBsXPQcO2QcRjkyHf6xCM6Hi1qQL4OnXMNE/ZTX0lnOj1/pH93TlzSHZMP TaiiA/MBD3vGsXBmBg== Organization: FreeBSD Message-ID: <0f2dd2ac-009a-4298-1007-2e4a7766b546@FreeBSD.org> Date: Thu, 24 May 2018 11:49:59 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <2E8F4907-F2AD-4EAD-A78F-E3236E516C8B@yahoo.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vy9WVSTv6BtQPvM2Zvg1ni8BO74Hqqmxl" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 18:50:02 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vy9WVSTv6BtQPvM2Zvg1ni8BO74Hqqmxl Content-Type: multipart/mixed; boundary="95OKvJKNoQ8TvcwuMENU8NEfDPOAW9JA5"; protected-headers="v1" From: Bryan Drewery To: Mark Millard , FreeBSD Current Cc: Cy.Schubert@cschubert.com, "O. Hartmann" Message-ID: <0f2dd2ac-009a-4298-1007-2e4a7766b546@FreeBSD.org> Subject: Re: Another recent WITH_META_MODE= gotcha ": handling svn commit: r334008 - head/bin/sh References: <2E8F4907-F2AD-4EAD-A78F-E3236E516C8B@yahoo.com> In-Reply-To: <2E8F4907-F2AD-4EAD-A78F-E3236E516C8B@yahoo.com> --95OKvJKNoQ8TvcwuMENU8NEfDPOAW9JA5 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/21/2018 10:17 PM, Mark Millard wrote: > Attempting to build head -r334014 from -r333947 includes the code from = -r334008, > and for which I get: >=20 > --- parser.o --- > /usr/src/bin/sh/parser.c:1440:9: error: use of undeclared identifier 'C= QNL' > case CQNL: > ^ > 1 error generated. >=20 > for what was added in -r334008. >=20 > # grep -r CQNL /usr/src/* | more > /usr/src/bin/sh/mksyntax.c: { "CQNL", "newline character in q= uotes" }, > /usr/src/bin/sh/mksyntax.c: add("\n", "CQNL"); > /usr/src/bin/sh/mksyntax.c: add("\n", "CQNL"); > /usr/src/bin/sh/mksyntax.c: add("\n", "CQNL"); > /usr/src/bin/sh/parser.c: case CQNL: > /usr/src/contrib/libarchive/libarchive/test/test_read_format_rar_binary= _data.rar.uu:M+M7)?9;.A%CQNL-+4::&_UJQ*P"PPW:>)I5*8)7^>6(\]!Q"^9YCE>>`9OG= 8 >=20 > Apparently this is something WITH_META_MODE=3D does not deal with. > Rebuilding after: >=20 > rm -fr /usr/obj/amd64_clang/* >=20 > (here I normally have the build materials) built fine. >=20 > (The "Making top.local.h from /usr/src/contrib/top/top.local.hs" > change to no longer have top.local.h or top.local.hs was another > example: for a while top.local.h was still referenced and old ones > would still be used if present.) >=20 It was a bug with the rescue build with dependency handling. I've fixed it in r334177. --=20 Regards, Bryan Drewery --95OKvJKNoQ8TvcwuMENU8NEfDPOAW9JA5-- --vy9WVSTv6BtQPvM2Zvg1ni8BO74Hqqmxl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJbBwlYAAoJEDXXcbtuRpfPlqIIAIIT4X3VyUIQ/FfHXOPuEj/5 S3GJrkl49uQrpz6/zFxWzKwwv142/zku3NVilXcQfExEgZjM3FXTbmgbSpJvslbu RdVjgzeAL+q5VPzdgqxkbbunMrWHumRqJWm9MYm3YPVdr72H+8HPyphfheC9UZ25 P8sO4j5o63m4LL5632k2hMatcLCgcyI5M3Kht76BtyGEYV+Z/lDHLs9agAxgcYf6 lPa8OWAwirAc6i7qBBwdSm/MIK3mKuJLEuxHf0WUDzVJEoevZ+9ymoY+DRv4qJCg e+J09rkDqloCAnVKHeHmJucm76ts2sSFiDupgnqTjf5YA/1x2WDNAOCfwmIMb84= =BC6L -----END PGP SIGNATURE----- --vy9WVSTv6BtQPvM2Zvg1ni8BO74Hqqmxl--