From owner-cvs-src@FreeBSD.ORG Wed Jun 7 17:21:27 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A3B4E16D53B; Wed, 7 Jun 2006 14:45:57 +0000 (UTC) (envelope-from john@baldwin.cx) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2124843D46; Wed, 7 Jun 2006 14:45:56 +0000 (GMT) (envelope-from john@baldwin.cx) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k57EjtHI069333; Wed, 7 Jun 2006 10:45:55 -0400 (EDT) (envelope-from john@baldwin.cx) From: John Baldwin To: Gleb Smirnoff Date: Wed, 7 Jun 2006 10:45:37 -0400 User-Agent: KMail/1.9.1 References: <200606071226.k57CQNvK018193@repoman.freebsd.org> In-Reply-To: <200606071226.k57CQNvK018193@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606071045.39131.john@baldwin.cx> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 07 Jun 2006 10:45:55 -0400 (EDT) X-Virus-Scanned: ClamAV 0.87.1/1518/Wed Jun 7 09:10:04 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/dc if_dc.c if_dcreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2006 17:21:29 -0000 On Wednesday 07 June 2006 08:26, Gleb Smirnoff wrote: > glebius 2006-06-07 12:26:23 UTC > > FreeBSD src repository > > Modified files: > sys/dev/dc if_dc.c if_dcreg.h > Log: > Add device IDs for Linksys PCMPC200 Cardbus card. > > PR: kern/75582 > Submitted by: Gary Palmer This doesn't work because you didn't handle the card in attach() and it probably worked by accident prior to my latest rounds of dc cleanups because attach() only checked half the PCI device ID before I fixed it. The patches on hackers@ for this that I planned to fixup to do this add two new device IDs not just one. :) I think you just need to add a 'case DC_DEVID(..., ...):' line to the appropriate entry. The patches on hackers let you know which entry in attach() they need to be added to. -- John Baldwin