From owner-svn-src-all@freebsd.org Tue Jan 15 00:33:56 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09AE2148C389; Tue, 15 Jan 2019 00:33:56 +0000 (UTC) (envelope-from jason.harmening@gmail.com) Received: from mail-it1-x12d.google.com (mail-it1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8FA4C84CE3; Tue, 15 Jan 2019 00:33:55 +0000 (UTC) (envelope-from jason.harmening@gmail.com) Received: by mail-it1-x12d.google.com with SMTP id z7so2576026iti.0; Mon, 14 Jan 2019 16:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kAsVfFsQGiloG+4s0Ooa/JA/N+AE/1J3AUEEvkwD4yw=; b=WtpFYL3A5emlPHYNKAeG+R3Uvcl60VtdHI8JlF3duNo/RaPvhYeHDw0OOuRHAb64xR sSQhmKqJMA52+mzAK89zofvTBz57EvL//VUKwMq4sxAc52DvFuQRQYKCsPQi2+vMWlU5 nE8pL6s3zTuU8M89SAOc5RUkEe+w7g/k29ogjLjPP9QrBur/T66l5DgCY7wtgaF85YNT U1SSe6mLrm1CWqB+zKe7oV98bnCVPWBbaCpt7GZ594Rzm0IYL1Na7ANSFolrOur5Jd9k 5kdX8+9XWtmKVYOm7f+YbQcQ1rKruPEe0tQGmSas0tp2Jy412sg+ZBoIe++Vy/8D+QiH Wcpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kAsVfFsQGiloG+4s0Ooa/JA/N+AE/1J3AUEEvkwD4yw=; b=m3PpCUbBQHnYX6AthtvMXqahYP27skPLcHfYcp//4/KHrjmPq8eZIeNKNg0bE6nSm6 hTpxI3dbexUmKZrHT5UKNHdNGrw4YwaBX63L8N/2zGVe3wqMSL7JB77pr8ZDJFu8xGWD HGNPkwKNsg+p/Y1kWw1kn/3O+F5e+00C3kUycJ1JEXgAceUtQwY2Fqj1WGsgLwUYQ79O hV7udedv2uerKzumbo+/rmiqWcqItgk4iAD1ng8ONueD4xvnWdKVxLRiqI6mrkQknv9V lNX6fBnt9oQXGsPoq7yQtuj0jsP6B6VkPfyGzAyLEPoUP+slOssiwU40+2GgMDBrl6FQ cy+Q== X-Gm-Message-State: AJcUukd7Z3VSGSX7TZGYS7wpKHv9rpj+TBBtWa5SRWmYN0dKLwd42J9L Ny3Qq2gAksb/au2na16P/VGrZrdWPyaMqPTjdpeg X-Google-Smtp-Source: ALg8bN6a/vNbcyJHHwl0l2vDU7fOnR2ujcv47UddBWswHH9XgNGRNymPl2z3Zz5eGz2J5lboNgEQSOxLIsU55bF+3dU= X-Received: by 2002:a02:84e1:: with SMTP id f88mr715327jai.107.1547512434568; Mon, 14 Jan 2019 16:33:54 -0800 (PST) MIME-Version: 1.0 References: <201901132033.x0DKXtin020499@repo.freebsd.org> <20190114232351.GS18452@FreeBSD.org> In-Reply-To: <20190114232351.GS18452@FreeBSD.org> From: Jason Harmening Date: Mon, 14 Jan 2019 16:33:43 -0800 Message-ID: Subject: Re: svn commit: r343005 - head/sys/kern To: Gleb Smirnoff Cc: "Jason A. Harmening" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 8FA4C84CE3 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.96)[-0.964,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 00:33:56 -0000 No problem! It was fun to dig into a part of the kernel I hadn't worked on before. On Mon, Jan 14, 2019 at 3:24 PM Gleb Smirnoff wrote: > Jason, > > thanks a lot for fixing this. > > On Sun, Jan 13, 2019 at 08:33:55PM +0000, Jason A. Harmening wrote: > J> Author: jah > J> Date: Sun Jan 13 20:33:54 2019 > J> New Revision: 343005 > J> URL: https://svnweb.freebsd.org/changeset/base/343005 > J> > J> Log: > J> Handle SIGIO for listening sockets > J> > J> r319722 separated struct socket and parts of the socket I/O path into > J> listening-socket-specific and dataflow-socket-specific pieces. > Listening > J> socket connection notifications are now handled by solisten_wakeup() > instead > J> of sowakeup(), but solisten_wakeup() does not currently post SIGIO to > the > J> owning process. > J> > J> PR: 234258 > J> Reported by: Kenneth Adelman > J> MFC after: 1 week > J> Differential Revision: https://reviews.freebsd.org/D18664 > J> > J> Modified: > J> head/sys/kern/uipc_socket.c > J> > J> Modified: head/sys/kern/uipc_socket.c > J> > ============================================================================== > J> --- head/sys/kern/uipc_socket.c Sun Jan 13 19:49:46 2019 > (r343004) > J> +++ head/sys/kern/uipc_socket.c Sun Jan 13 20:33:54 2019 > (r343005) > J> @@ -886,6 +886,8 @@ solisten_wakeup(struct socket *sol) > J> } > J> SOLISTEN_UNLOCK(sol); > J> wakeup_one(&sol->sol_comp); > J> + if ((sol->so_state & SS_ASYNC) && sol->so_sigio != NULL) > J> + pgsigio(&sol->so_sigio, SIGIO, 0); > J> } > J> > J> /* > J> > > -- > Gleb Smirnoff >