Date: Thu, 4 Nov 2010 08:51:45 +0000 (UTC) From: Andriy Gapon <avg@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/amd64/amd64 mp_machdep.c src/sys/i386/i386 mp_machdep.c Message-ID: <201011042110.oA4LAMJR021522@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
avg 2010-11-04 08:51:45 UTC
FreeBSD src repository
Modified files:
sys/amd64/amd64 mp_machdep.c
sys/i386/i386 mp_machdep.c
Log:
SVN rev 214774 on 2010-11-04 08:51:45Z by avg
x86 topo_probe: do not probe smp topology if only one cpu is visible
This could lead to a division by zero if hardware is multi-core and/or
multi-threaded, but for some (quite unusual) reason FreeBSD sees only
one logical processor. This could happen, for example, if neither MADT
nor MP Table are presented by BIOS.
Also:
- assert in topo_probe_0x4 that BSP is accounted for
- neither cpu_cores nor cpu_logical should be zero after successful
probing, so either being zero is an indication of failed probing
Reported by: vwe, Dan Allen <danallen46@airwired.net>
Tested by: Dan Allen <danallen46@airwired.net>
MFC after: 3 days
Revision Changes Path
1.336 +8 -5 src/sys/amd64/amd64/mp_machdep.c
1.322 +8 -5 src/sys/i386/i386/mp_machdep.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011042110.oA4LAMJR021522>