From owner-p4-projects@FreeBSD.ORG  Wed Mar 15 23:43:38 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 6C4FD16A426; Wed, 15 Mar 2006 23:43:38 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 436A816A400
	for <perforce@freebsd.org>; Wed, 15 Mar 2006 23:43:38 +0000 (UTC)
	(envelope-from peter@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 71BE043DC3
	for <perforce@freebsd.org>; Wed, 15 Mar 2006 23:43:17 +0000 (GMT)
	(envelope-from peter@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k2FNhHH5005068
	for <perforce@freebsd.org>; Wed, 15 Mar 2006 23:43:17 GMT
	(envelope-from peter@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k2FNhHBN005065
	for perforce@freebsd.org; Wed, 15 Mar 2006 23:43:17 GMT
	(envelope-from peter@freebsd.org)
Date: Wed, 15 Mar 2006 23:43:17 GMT
Message-Id: <200603152343.k2FNhHBN005065@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	peter@freebsd.org using -f
From: Peter Wemm <peter@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 93380 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Mar 2006 23:43:38 -0000

http://perforce.freebsd.org/chv.cgi?CH=93380

Change 93380 by peter@peter_melody on 2006/03/15 23:43:08

	Slight optimization.  If we're going to test the map for nonzero, use
	that to terminate the loop.  Use the loop termination condition to measure
	success.

Affected files ...

.. //depot/projects/hammer/sys/amd64/amd64/pmap.c#143 edit

Differences ...

==== //depot/projects/hammer/sys/amd64/amd64/pmap.c#143 (text+ko) ====

@@ -1593,13 +1593,12 @@
 	pc = TAILQ_FIRST(&pmap->pm_pvchunk);
 	if (pc != NULL) {
 		for (field = 0; field < _NPCM; field++) {
-			bit = -1;
-			if (pc->pc_map[field])
+			if (pc->pc_map[field]) {
 				bit = bsfq(pc->pc_map[field]);
-			if (bit >= 0)
 				break;
+			}
 		}
-		if (bit >= 0) {
+		if (field < _NPCM) {
 			pv = &pc->pc_pventry[field * 64 + bit];
 			pc->pc_map[field] &= ~(1ul << bit);
 			/* If this was the last item, move it to tail */