From owner-freebsd-ports@FreeBSD.ORG Sat Feb 21 23:16:30 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 25A4B106566B for ; Sat, 21 Feb 2009 23:16:30 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmmtao106.cox.net (eastrmmtao106.cox.net [68.230.240.48]) by mx1.freebsd.org (Postfix) with ESMTP id BA09C8FC16 for ; Sat, 21 Feb 2009 23:16:29 +0000 (UTC) (envelope-from mezz7@cox.net) Received: from eastrmimpo03.cox.net ([68.1.16.126]) by eastrmmtao106.cox.net (InterMail vM.7.08.02.01 201-2186-121-102-20070209) with ESMTP id <20090221231629.TBIX18213.eastrmmtao106.cox.net@eastrmimpo03.cox.net>; Sat, 21 Feb 2009 18:16:29 -0500 Received: from localhost ([68.103.37.153]) by eastrmimpo03.cox.net with bizsmtp id qPVE1a00Z3JFCbG02PVFbY; Fri, 12 Dec 2008 18:29:15 -0500 X-Authority-Analysis: v=1.0 c=1 a=TxPOhCHYrsIA:10 a=6I5d2MoRAAAA:8 a=pGLkceISAAAA:8 a=kviXuzpPAAAA:8 a=EsYYc83e12BmZFijw_sA:9 a=vAuHhoRS92xgqMZYODYA:7 a=yVwtVnHkmxS04p-bQQQKct878yUA:4 a=LY0hPdMaydYA:10 a=SV7veod9ZcQA:10 a=MSl-tDqOz04A:10 a=4vB-4DCPJfMA:10 X-CM-Score: 0.00 Date: Sat, 21 Feb 2009 17:16:08 -0600 To: "Max Brazhnikov" From: "Jeremy Messenger" Content-Type: text/plain; format=flowed; delsp=yes; charset=utf-8 MIME-Version: 1.0 References: <86bpsw2tbf.fsf@gmail.com> <20090221104501.06e778f1@it.buh.tecnik93.com> <86r61svw0u.fsf@gmail.com> <200902211548.57102.makc@freebsd.org> Content-Transfer-Encoding: 7bit Message-ID: In-Reply-To: <200902211548.57102.makc@freebsd.org> User-Agent: Opera Mail/9.63 (Linux) Cc: Anonymous , freebsd-ports@freebsd.org Subject: Re: git snapshots, PORTVERSION, PORTEPOCH X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2009 23:16:30 -0000 On Sat, 21 Feb 2009 06:48:56 -0600, Max Brazhnikov wrote: > On Sat, 21 Feb 2009 15:01:37 +0300, Anonymous wrote: >> Ion-Mihai Tetcu writes: >> > On Sat, 21 Feb 2009 09:32:52 +0300 >> > >> > Anonymous wrote: >> >> Would it be okay if I use commit hash in PORTVERSION and constantly >> >> bump PORTEPOCH on each update? Are there any such precedents? >> >> >> >> %%% >> >> PORTVERSION= 0.0.10${SNAPSUFFIX} >> >> PORTEPOCH= 1 >> >> >> >> SNAPSUFFIX= .${SNAPTYPE}.${SNAPREV} >> >> SNAPTYPE= git >> >> SNAPREV= e09f50e >> >> %%% >> >> >> >> Where PKGNAME would look like >> >> >> >> myport-0.0.10.git.e09f50e,1 >> >> >> >> I want to keep commit reference in place and refrain from using vague >> >> dates in PORTVERSION because there can be several commits per day. >> And >> >> for curious users I can include ChangeLog file in distfile generated >> >> from git-log command. >> > >> > No, please don't do this. We use PORTEPOCH when there's no other way. >> >> OK. I can include date before commit hash and drop use of PORTEPOCH. >> It would look like >> >> SNAPSUFFIX= .20090219.e09f50e > Please, see http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters- > handbook/makefile-naming.html#PORTING-PKGNAME > Using 'e09f50e' in PORTVERSION is not a good idea. However you can use > your > ${SNAPREV} in DISTVERSION. I agree, but I am not sure if that sha256 (or whatever what git uses hash) will be always higher letters+numbers in combo? If so, please use the date instead or figure something else better. It will working with SVN as it always bump higher r+numbers. Cheers, Mezz >> Any other objections? >> >> > Use, like other ports do: >> > PORTVERSION= 0.0.10 >> > PORTREVISION= ${SNAPDATE} >> > >> > I don't see what role SNAPTYPE would have. >> >> SNAPTYPE isn't neccessary, just a little convenience. >> >> > Since you have the date, you can easily get the git magic string. >> >> Dates aren't atomic. That would require precise dates up to seconds and >> still leave place for ambiguity. I opt to not drop git magic string if >> possible else talking to upstream would be a little harder. > > _______________________________________________ > freebsd-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" -- mezz7@cox.net - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org