Date: Sun, 6 May 2018 15:51:55 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Koichiro Iwao <meta@FreeBSD.org> Cc: Kurt Jaeger <pi@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r469188 - head/ports-mgmt/pkg_replace Message-ID: <20180506155155.GC79630@FreeBSD.org> In-Reply-To: <01010163359962dc-36ee8574-dbd7-4cc6-8032-e04a80a18f1e-000000@us-west-2.amazonses.com> References: <201805061015.w46AF3HQ070595@repo.freebsd.org> <20180506102749.GA58637@FreeBSD.org> <20180506103420.GW25490@fc.opsec.eu> <20180506105012.GA39087@FreeBSD.org> <01010163359962dc-36ee8574-dbd7-4cc6-8032-e04a80a18f1e-000000@us-west-2.amazonses.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 06, 2018 at 01:17:14PM +0000, Koichiro Iwao wrote: > On Sun, May 06, 2018 at 10:50:12AM +0000, Alexey Dokuchaev wrote: > > *facepalm*. This poudriere-driven development is more and more disturbing. > > You didn't attempt to understand the problem, you didn't attempt to fix the > > PLIST_FILES (remove bogus %%ETCDIR%% since this is Makefile), you didn't > > ask for a peer review. meta@ pessimized the port, provided wrong commit > > log (it tells *nothing* about poudriere failing with a signal 6 in make > > package, it says "pet portlint"), and you've approved it like there's > > nothing wrong with all of this. :-( > > Sorry about that. I understand what I should have done and I could do. Oh I don't blame you at all. Your mentor is currently earning all the pointy hats. :-) > Then what should I do next? Should I turn back to PLIST_FILES? That would be what we call "gratuitous change" here. The deed was done, if it works, leave it. You might want to revisit it later alongside with other changes. > What should I do from the next time not to repeat such a folly? Study PHB and other people's work (I understand that not everyone has time or desire to read through all svn-ports-* emails, but being a new committer it could be helpful for you at least in the beginning). Study other ports, often they can offer nice a idea (bad ones as well, more often). Question your decisions, question others' decisions, when it doubt, ask for a peer review. There are quite a few highly qualified and experienced committers. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180506155155.GC79630>