From owner-freebsd-bugs@FreeBSD.ORG  Sun Oct  7 16:14:20 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id CAF15106566B;
	Sun,  7 Oct 2012 16:14:20 +0000 (UTC)
	(envelope-from marcel@xcllnt.net)
Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 672628FC0A;
	Sun,  7 Oct 2012 16:14:20 +0000 (UTC)
Received: from sa-nc-cs-116.static.jnpr.net (natint3.juniper.net
	[66.129.224.36]) (authenticated bits=0)
	by mail.xcllnt.net (8.14.5/8.14.5) with ESMTP id q97GEIRG060706
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
	Sun, 7 Oct 2012 09:14:19 -0700 (PDT)
	(envelope-from marcel@xcllnt.net)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\))
From: Marcel Moolenaar <marcel@xcllnt.net>
In-Reply-To: <CAGH67wR9P_QzR0Wd8EUd5EQ0xuLqVssGjsmZNEt+-7iiL1DGXg@mail.gmail.com>
Date: Sun, 7 Oct 2012 09:14:13 -0700
Content-Transfer-Encoding: 7bit
Message-Id: <F5ADC56B-A7B9-4E0B-9869-AEB75C47D558@xcllnt.net>
References: <201210070701.q977170a033550@red.freebsd.org>
	<201210070710.q977A9p8087371@freefall.freebsd.org>
	<CAGH67wR9P_QzR0Wd8EUd5EQ0xuLqVssGjsmZNEt+-7iiL1DGXg@mail.gmail.com>
To: Garrett Cooper <yanegomi@gmail.com>
X-Mailer: Apple Mail (2.1499)
Cc: Max Khon <fjoe@freebsd.org>, freebsd-bugs@freebsd.org,
	Marcel Moolenaar <marcel@freebsd.org>, "Simon J. Gerraty" <sjg@NetBSD.org>
Subject: Re: misc/172440: [patch] [build] fix broken CTFCONVERT_CMD call
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Oct 2012 16:14:20 -0000


On Oct 7, 2012, at 1:48 AM, Garrett Cooper <yanegomi@gmail.com> wrote:

> <fix-MAKE_VERSION-nul-CTFCONVERT_CMD-check.patch.txt>


Please don't use WITH_BMAKE. It's only added for handling
the switch. The option will be removed soon.

BTW: Isn't it easier to introduce a CC_CMD variable that
contains at least the compile command and to which you can
append any commands you want?

Not only does that eliminate the problem at hand, it also
makes the whole think a lot less like a one-off hack, and
more like a fundamental feature.

Other things we may want to do after we compile a file is
generate API/ABI information that we can validate so that
we can fail the build when some code change breaks the ABI
or API.

Thoughts?

-- 
Marcel Moolenaar
marcel@xcllnt.net