From owner-cvs-src@FreeBSD.ORG Tue Oct 19 17:43:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 67E4616A4D0 for ; Tue, 19 Oct 2004 17:43:08 +0000 (GMT) Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id E417F43D58 for ; Tue, 19 Oct 2004 17:43:07 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 4549 invoked from network); 19 Oct 2004 17:43:07 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 19 Oct 2004 17:43:07 -0000 Received: from hydrogen.funkthat.com (inaxyd@localhost.funkthat.com [127.0.0.1])i9JHh6lb067723; Tue, 19 Oct 2004 10:43:07 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id i9JHh670067722; Tue, 19 Oct 2004 10:43:06 -0700 (PDT) Date: Tue, 19 Oct 2004 10:43:06 -0700 From: John-Mark Gurney To: Kenneth Culver Message-ID: <20041019174306.GK22681@funkthat.com> References: <200410182306.i9IN6DDx016512@repoman.freebsd.org> <20041019101752.e8ws08k8kcw8408c@www.sweetdreamsracing.biz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041019101752.e8ws08k8kcw8408c@www.sweetdreamsracing.biz> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_de.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2004 17:43:08 -0000 Kenneth Culver wrote this message on Tue, Oct 19, 2004 at 10:17 -0400: > Quoting John-Mark Gurney : > > >jmg 2004-10-18 23:06:13 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/pci if_de.c > > Log: > > fix (for me) the problems where if_de gets really slow after time > > (usually taking 20 seconds to transmit a packet).. no longer fall back > > to only transmitting one packet (instead of the entire queue) after we > > have processed the entire send queue... I have no idea why we didn't > > start seeing this problem ~6 years ago when this code was introduced... > > Do you get an error on boot with this device about it running in Giant. I > was > seeing similar problems to you and I was seeing a message at boot about this > device running in Giant, so I set debug.mpsafenet to 0, and the problem went > away. yes, I do: de0: port 0xd800-0xd87f mem 0xe8000000-0xe800007f irq 10 at device 9.0 on pci0 de0: [GIANT-LOCKED] de0: 21140A [10-100Mb/s] pass 2.2 de0: Ethernet address: 00:c0:f0:1f:21:f9 de0: if_start running deferred for Giant but even with those messages about Giant, we did find that the interface ioctl was being called w/o Giant... also, the warning about Giant mean that the network subsystem is suppose to call all of the driver's routines w/ Giant held to appear as if debug.mpsafenet has been set to 0.. I have a patch that addes some Giant requireds, but they can't be commited till the ioctl problem is fixed... If you are interested in tracking down the bug, I'll be more than happy to review and commit any changes... The driver needs to be both locked and busdma'ified... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."