From owner-freebsd-security@FreeBSD.ORG Wed Apr 6 11:42:59 2005 Return-Path: Delivered-To: freebsd-security@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C849516A4CE for ; Wed, 6 Apr 2005 11:42:59 +0000 (GMT) Received: from mailhost.stack.nl (vaak.stack.nl [131.155.140.140]) by mx1.FreeBSD.org (Postfix) with ESMTP id 07DE143D45 for ; Wed, 6 Apr 2005 11:42:59 +0000 (GMT) (envelope-from marcolz@stack.nl) Received: from hammer.stack.nl (hammer.stack.nl [IPv6:2001:610:1108:5010::153]) by mailhost.stack.nl (Postfix) with ESMTP id 1EE271F1DD; Wed, 6 Apr 2005 13:42:58 +0200 (CEST) Received: by hammer.stack.nl (Postfix, from userid 333) id F3EB4618D; Wed, 6 Apr 2005 13:42:57 +0200 (CEST) Date: Wed, 6 Apr 2005 13:42:57 +0200 From: Marc Olzheim To: Uwe Doering Message-ID: <20050406114257.GA22448@stack.nl> References: <200504050009.j35099Zr068123@freefall.freebsd.org> <425248D8.1040508@geminix.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z" Content-Disposition: inline In-Reply-To: <425248D8.1040508@geminix.org> X-Operating-System: FreeBSD hammer.stack.nl 5.4-STABLE FreeBSD 5.4-STABLE X-URL: http://www.stack.nl/~marcolz/ User-Agent: Mutt/1.5.9i cc: freebsd-security@freebsd.org Subject: Re: FreeBSD Security Advisory FreeBSD-SA-05:02.sendfile X-BeenThere: freebsd-security@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Security issues [members-only posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2005 11:42:59 -0000 --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 05, 2005 at 10:14:16AM +0200, Uwe Doering wrote: > I can't tell why 'ovp' was introduced in the first place. Might have=20 > historical reasons. But that's how the code currently works. In the=20 > MAIN branch as well, according to CVS. So I'd suggest to replace 'vp'=20 > with 'ovp' in the patch above, for the sake of clarity and consistency. It's a remnant from sys/ufs/ffs/ffs_inode.c:1.27 - 1.28, when the arguments of ffs_truncate changed from (ap), to (vp, length, flags, cred, p) and ovp was declared as 'register struct vnode *vp =3D ap->a_vp;'. This could be cleaned up without problems. Marc --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFCU8tBezjnobFOgrERAvSSAKCuM3WCuoL5yn+L0kgtj1UJhkGF/wCeNZz5 twShJMn5nPlYbz+SXGr733c= =iEYG -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--