From owner-freebsd-current@freebsd.org  Wed Aug 29 23:40:58 2018
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 732A31089859
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Wed, 29 Aug 2018 23:40:58 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 21AC986FB8
 for <freebsd-current@freebsd.org>; Wed, 29 Aug 2018 23:40:58 +0000 (UTC)
 (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx
 [66.234.199.215])
 by mail.baldwin.cx (Postfix) with ESMTPSA id C764510AFD2;
 Wed, 29 Aug 2018 19:40:56 -0400 (EDT)
Subject: Re: intr_machdep.c:176:2: error: use of undeclared identifier
 'interrupt_sorted'
To: Ian FREISLICH <ian.freislich@capeaugusta.com>,
 freebsd-current <freebsd-current@freebsd.org>
References: <524214ac-e3ca-53cd-aee3-dac9212e9800@capeaugusta.com>
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <0aa35f96-9f62-bfca-c04a-f6ddcb1ce738@FreeBSD.org>
Date: Wed, 29 Aug 2018 16:40:54 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <524214ac-e3ca-53cd-aee3-dac9212e9800@capeaugusta.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Wed, 29 Aug 2018 19:40:57 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Aug 2018 23:40:58 -0000

On 8/29/18 4:20 PM, Ian FREISLICH wrote:
> Hi
> 
> I see the definition of interrupt_sorted is #ifdefed out by #ifdef SMP
> at line 84.  My system is UP <gasp> so I'm not compiling an SMP kernel.
> 
> /usr/src/sys/x86/x86/intr_machdep.c:176:2: error: use of undeclared
> identifier 'interrupt_sorted'; did you mean 'interrupt_sources'?
>         interrupt_sorted = mallocarray(num_io_irqs,
> sizeof(*interrupt_sorted),
>         ^~~~~~~~~~~~~~~~
>         interrupt_sources
> /usr/src/sys/x86/x86/intr_machdep.c:83:24: note: 'interrupt_sources'
> declared here
> static struct intsrc **interrupt_sources;
>                        ^
> /usr/src/sys/x86/x86/intr_machdep.c:176:54: error: use of undeclared
> identifier 'interrupt_sorted'; did you mean 'interrupt_sources'?
>         interrupt_sorted = mallocarray(num_io_irqs,
> sizeof(*interrupt_sorted),

Probably just needs #ifdef SMP around the mallocarray().  I'll test locallyon a UP kernel config.

-- 
John Baldwin