From owner-dev-commits-src-all@freebsd.org Tue Aug 31 07:54:37 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8206F668217; Tue, 31 Aug 2021 07:54:37 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GzKGP2V1fz4cSN; Tue, 31 Aug 2021 07:54:37 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 0CA6294E4; Tue, 31 Aug 2021 07:54:37 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 0B41C2D472; Tue, 31 Aug 2021 09:54:33 +0200 (CEST) From: Kristof Provost To: Konstantin Belousov Cc: Dimitry Andric , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 5b8f07b12f84 - main - Fix -Wformat errors in pfctl on 32-bit architectures Date: Tue, 31 Aug 2021 09:54:32 +0200 X-Mailer: MailMate (1.14r5818) Message-ID: In-Reply-To: References: <202108291531.17TFVoah033310@gitrepo.freebsd.org> <6A084192-562D-404D-9833-51A708FA1BC0@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2021 07:54:37 -0000 On 31 Aug 2021, at 1:33, Konstantin Belousov wrote: > On Sun, Aug 29, 2021 at 07:40:09PM +0200, Dimitry Andric wrote: >> On 29 Aug 2021, at 18:00, Kristof Provost wrote: >>> >>> On 29 Aug 2021, at 17:31, Dimitry Andric wrote: >>>> The branch main has been updated by dim: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D5b8f07b12f8477f167901= 3d6b3abdab8d33c7243 >>>> >>>> commit 5b8f07b12f8477f1679013d6b3abdab8d33c7243 >>>> Author: Dimitry Andric >>>> AuthorDate: 2021-08-29 15:31:28 +0000 >>>> Commit: Dimitry Andric >>>> CommitDate: 2021-08-29 15:31:28 +0000 >>>> >>>> Fix -Wformat errors in pfctl on 32-bit architectures >>>> >>>> Use PRIu64 to printf(3) uint64_t quantities, otherwise this will = result >>>> in "error: format specifies type 'unsigned long' but the argument= has >>>> type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]" on= 32-bit >>>> architectures. >>>> >>>> Fixes: 80078d9d38fd >>>> MFC after: 1 week >>> >>> Thanks! >>> >>> I was running test builds for a fix, but it is so much more convenien= t when other people fix my mistakes for me. >> >> I was trying buildworld on i386 for something totally unrelated, and r= an >> into these -Wformat errors so I took the liberty of patching them up >> quickly. :) > > Generally we do not use the PRIu64 (you should remember the term > abomination). Why not cast to uintmax_t and use %ju as we typically do= > in other places. > There are a couple of examples in the tree, but it is indeed rare. I wanted to avoid casting so that the compiler would still shout at me if= data types changed. It=E2=80=99s much easier to miss places where a vari= able is used (and that need to be updated) if they=E2=80=99re getting cas= t to something. If this is something the project has strong feelings about I=E2=80=99ll c= hange it, but I think I like this slightly better than casting to uintmax= _t. Best regards, Kristof